Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP1Fast matcher omits PATCH #99

Open
yvrhdn opened this issue Aug 8, 2023 · 2 comments
Open

HTTP1Fast matcher omits PATCH #99

yvrhdn opened this issue Aug 8, 2023 · 2 comments

Comments

@yvrhdn
Copy link

yvrhdn commented Aug 8, 2023

Hi, cmux has been working great for us. Recently we added a PATCH endpoint to our application and were surprised the HTTP1Fast matcher doesn't automatically match on PATCH.
Is there a particular reason for not including PATCH or is this an oversight?

All other methods are in there except PATCH and OPTIONS.

cmux/matchers.go

Lines 46 to 55 in 5ec6847

var defaultHTTPMethods = []string{
"OPTIONS",
"GET",
"HEAD",
"POST",
"PUT",
"DELETE",
"TRACE",
"CONNECT",
}

@buzzy
Copy link

buzzy commented Aug 14, 2023

I might be crazy, but I see "OPTIONS" in that list.

@yvrhdn
Copy link
Author

yvrhdn commented Aug 16, 2023

Oh oops, must have read over it. I was comparing it to another list of HTTP methods and didn't expect it at the top of the list I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants