-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't include idle-vue component in default build #27
Comments
Totally agree. This will be removed in the next version. In the mean time if you fix this, we will be happy to merge. |
Okay I'll have a look.
|
@gabrielstuff Firstly, nice package! This issue is a nice addition. Do you intend to merge and publish? Thanks. |
Hello, |
When will this be merged? |
I see this was merged in but a new release was not published to NPM. |
Will publish tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For most people this is just bloat, most people will not use this component so you're just adding kB to their JS asset size. Just include it in the package as an example or to be extended or whatever. Anyone who wants to use this component can include it themselves.
For most people it will not work properly since it tried to request a PNG icon at a path that almost nobody will use.
The text was updated successfully, but these errors were encountered: