Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning on/off a filter adds those types of proposals to the top instead of putting them all together #316

Open
RaymondDashWu opened this issue Feb 6, 2022 · 6 comments

Comments

@RaymondDashWu
Copy link
Contributor

Before
image

After adding drafts to filter
image

Expected there to be various completed results as those were more recent

@appsplash99
Copy link

Just wanted to understand the problem better...

Is the list supposed to be arranged in ascending order with all the list items??

whereas, its currrently its just pushing all the draft items in the starting oof the list items...

am i correct??

@RaymondDashWu
Copy link
Contributor Author

Yup that's correct. Ascending order of dates. Current logic pushes all draft items to the top.

@appsplash99
Copy link

I can take a look at it.
can you assign it to me ??

@RaymondDashWu
Copy link
Contributor Author

I'm not a maintainer so I don't have the power to assign that. I just noticed the bug when using the UI.

@masayafunakoshi1
Copy link
Contributor

I'll take a look at this too, I just dealt with filters, so can probably figure out how it works

@masayafunakoshi1
Copy link
Contributor

Actually, it's probably better to keep the drafts at the top of the list. Because the only reason people might want to see the drafts is to access them again to deploy a proposal. So it would make sense it goes to the top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants