token-cli: Unable to use the token cli to transfer tokens that have the transfer-fee and transfer-hook extensions.

[tonton-sol]

I am trying to test using the transfer-fee extension in conjunction with the transfer-hook extension. The transfer-hook is the provided example program given in this repository. The transfer hook extra account metas account is initialized but empty. I am running this command:

spl-token transfer --expected-fee <EXPECTED_FEE> <TOKEN_MINT_ADDRESS> <TOKEN_AMOUNT> <RECIPIENT_WALLET_ADDRESS>

It fails with error: Program TokenzQdBNbLqP5VEhdkAS6EPFLC1PHnBqCXEpPxuEb failed: custom program error: 0x7dc8348c My suspicion is that TransferCheckedWithFee is not correctly resolving the extra account metas.

I have already confirmed that this same transfer-hook program works and successfully transfers a token with only the transfer-hook extension.

Solution: Fix TransferCheckedWithFee to correctly resolve the required extra account metas.

[joncinque]

Thanks for your report! This is indeed an issue.

It looks like we'll need to do a few things to fix this properly.

• in token-2022, add an offchain helper (and probably an onchain helper while we're at it) which also takes in the expected fee, something like create_transfer_checked_with_fee_instruction_with_extra_metas, which could resolve to some common helper function with

  solana-program-library/token/program-2022/src/offchain.rs

  Line 37 in 7d35ad2

  pub async fn create_transfer_checked_instruction_with_extra_metas<F, Fut>(

• in token-client, use that offchain helper in transfer_with_fee

  solana-program-library/token/client/src/token.rs

  Line 1149 in 7d35ad2

  pub async fn transfer_with_fee<S: Signers>(

  , very similar to how the transfer function works

  solana-program-library/token/client/src/token.rs

  Line 992 in 7d35ad2

  pub async fn transfer<S: Signers>(

• token-cli already uses transfer_with_fee, so that should Just Work afterwards

[tonton-sol]

I will start on this!

[joncinque]

Resolved by #7171, thanks!