-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token collection: create spec program #5614
token collection: create spec program #5614
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
946b876
to
c2a8050
Compare
3ea69bb
to
6c2c09e
Compare
d2916be
to
052500a
Compare
6c2c09e
to
7119ded
Compare
052500a
to
8531594
Compare
7119ded
to
4efcbc1
Compare
8531594
to
2ce7dd4
Compare
5269a5f
to
ea2dad4
Compare
ea2dad4
to
88a4581
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan of the test and the program!
There's a lot of duplicated code between the base example and this one -- it seems like the only difference is the metadata pointer + metadata check, and the ability to have multiple member entries in a group. Anything else?
I'm not sure if there's a good way to resolve that. We could do it through a feature or by exporting everything from the example to be reused here. Or maybe we keep it as is, since it's not too much code. What do you think?
Yeah, I agree there's a lot of similarity. Given that it's really only a processor, I've decided to add a commit for importing the example program's processor functions for I think this is the best we can do with sharing code from the example program. Let me know what you think, and if you think it's not confusing to onlookers. |
5f137d2
to
7151874
Compare
7151874
to
17c963d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I do like the reusing of the example program processors, makes them seem more generally useful
Ok, I threw this together to see what we think of it. A reference example of using SPL Token Group to make a Collections program.