From 1adf435cfc724303f64e509a6fda144ec8f5019d Mon Sep 17 00:00:00 2001 From: leant <155785958+leantOnSol@users.noreply.github.com> Date: Tue, 12 Nov 2024 05:33:46 +0100 Subject: [PATCH] manifest fixes (#3552) * rm engine fields, update root manifest engines version * Add changeset for #3552 --------- Co-authored-by: Steven Luscher --- .changeset/empty-wombats-guess.md | 20 +++++++++++++++++++ package.json | 3 +-- packages/addresses/package.json | 3 --- packages/assertions/package.json | 3 --- packages/codecs-core/package.json | 3 --- packages/codecs-data-structures/package.json | 3 --- packages/codecs-numbers/package.json | 3 --- packages/codecs-strings/package.json | 3 --- packages/compat/package.json | 3 --- packages/errors/package.json | 3 --- packages/keys/package.json | 3 --- packages/options/package.json | 3 --- packages/react/package.json | 3 --- packages/signers/package.json | 3 --- packages/subscribable/package.json | 3 --- packages/sysvars/package.json | 3 --- .../transaction-confirmation/package.json | 3 --- .../webcrypto-ed25519-polyfill/package.json | 3 --- 18 files changed, 21 insertions(+), 50 deletions(-) create mode 100644 .changeset/empty-wombats-guess.md diff --git a/.changeset/empty-wombats-guess.md b/.changeset/empty-wombats-guess.md new file mode 100644 index 000000000000..180fafcaeac6 --- /dev/null +++ b/.changeset/empty-wombats-guess.md @@ -0,0 +1,20 @@ +--- +"@solana/addresses": patch +"@solana/assertions": patch +"@solana/codecs-core": patch +"@solana/codecs-data-structures": patch +"@solana/codecs-numbers": patch +"@solana/codecs-strings": patch +"@solana/compat": patch +"@solana/errors": patch +"@solana/keys": patch +"@solana/options": patch +"@solana/react": patch +"@solana/signers": patch +"@solana/subscribable": patch +"@solana/sysvars": patch +"@solana/transaction-confirmation": patch +"@solana/webcrypto-ed25519-polyfill": patch +--- + +A two-versions-old version of Node LTS is now specified everywhere via the `engines` field, including the one in the root of the `pnpm` workspace, and engine-strictness is delegated to the `.npmrc` files. diff --git a/package.json b/package.json index 4a7705c34eb4..a0405f21aac1 100644 --- a/package.json +++ b/package.json @@ -53,9 +53,8 @@ "typedoc-plugin-missing-exports": "^3.0.0", "typescript": "^5.6.3" }, - "engineStrict": true, "engines": { - "node": ">=14.0.0", + "node": ">=20.18.0", "npm": "please-use-pnpm", "pnpm": "^9", "yarn": "please-use-pnpm" diff --git a/packages/addresses/package.json b/packages/addresses/package.json index 675522ec0cf3..4c5f04b76980 100644 --- a/packages/addresses/package.json +++ b/packages/addresses/package.json @@ -70,9 +70,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/assertions": "workspace:*", "@solana/codecs-core": "workspace:*", diff --git a/packages/assertions/package.json b/packages/assertions/package.json index b297897f7129..fc3712ea645d 100644 --- a/packages/assertions/package.json +++ b/packages/assertions/package.json @@ -70,9 +70,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/errors": "workspace:*" }, diff --git a/packages/codecs-core/package.json b/packages/codecs-core/package.json index 0996c5dd24d8..a3976c98aa13 100644 --- a/packages/codecs-core/package.json +++ b/packages/codecs-core/package.json @@ -71,9 +71,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/errors": "workspace:*" }, diff --git a/packages/codecs-data-structures/package.json b/packages/codecs-data-structures/package.json index c59db35a3867..5bdddbc8622c 100644 --- a/packages/codecs-data-structures/package.json +++ b/packages/codecs-data-structures/package.json @@ -70,9 +70,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/codecs-core": "workspace:*", "@solana/codecs-numbers": "workspace:*", diff --git a/packages/codecs-numbers/package.json b/packages/codecs-numbers/package.json index f7b5cefc5a26..681f646079ae 100644 --- a/packages/codecs-numbers/package.json +++ b/packages/codecs-numbers/package.json @@ -70,9 +70,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/codecs-core": "workspace:*", "@solana/errors": "workspace:*" diff --git a/packages/codecs-strings/package.json b/packages/codecs-strings/package.json index 52cd5a981a19..44b95501ae2a 100644 --- a/packages/codecs-strings/package.json +++ b/packages/codecs-strings/package.json @@ -71,9 +71,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/codecs-core": "workspace:*", "@solana/codecs-numbers": "workspace:*", diff --git a/packages/compat/package.json b/packages/compat/package.json index 2c4a64ce36de..321d9ce1c0e4 100644 --- a/packages/compat/package.json +++ b/packages/compat/package.json @@ -70,9 +70,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/addresses": "workspace:*", "@solana/codecs-core": "workspace:*", diff --git a/packages/errors/package.json b/packages/errors/package.json index 8793643d3cab..0ed05d6cd647 100644 --- a/packages/errors/package.json +++ b/packages/errors/package.json @@ -71,9 +71,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "chalk": "^5.3.0", "commander": "^12.1.0" diff --git a/packages/keys/package.json b/packages/keys/package.json index e2b54a1d6e4b..553db1832d08 100644 --- a/packages/keys/package.json +++ b/packages/keys/package.json @@ -71,9 +71,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/assertions": "workspace:*", "@solana/codecs-core": "workspace:*", diff --git a/packages/options/package.json b/packages/options/package.json index 73b8199c1b88..9756f09fe0c9 100644 --- a/packages/options/package.json +++ b/packages/options/package.json @@ -70,9 +70,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/codecs-core": "workspace:*", "@solana/codecs-data-structures": "workspace:*", diff --git a/packages/react/package.json b/packages/react/package.json index 07098cece2dc..ea7cc3431803 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -70,9 +70,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/addresses": "workspace:*", "@solana/errors": "workspace:*", diff --git a/packages/signers/package.json b/packages/signers/package.json index 4612e691e5b1..80d02e56e5e5 100644 --- a/packages/signers/package.json +++ b/packages/signers/package.json @@ -70,9 +70,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/addresses": "workspace:*", "@solana/codecs-core": "workspace:*", diff --git a/packages/subscribable/package.json b/packages/subscribable/package.json index 12679b80d3d2..0b0d12cff719 100644 --- a/packages/subscribable/package.json +++ b/packages/subscribable/package.json @@ -70,9 +70,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/errors": "workspace:*" }, diff --git a/packages/sysvars/package.json b/packages/sysvars/package.json index b02f7338404b..03eef8284ad4 100644 --- a/packages/sysvars/package.json +++ b/packages/sysvars/package.json @@ -70,9 +70,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/accounts": "workspace:*", "@solana/codecs": "workspace:*", diff --git a/packages/transaction-confirmation/package.json b/packages/transaction-confirmation/package.json index d3beee4c412a..3df8cabe5808 100644 --- a/packages/transaction-confirmation/package.json +++ b/packages/transaction-confirmation/package.json @@ -69,9 +69,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@solana/addresses": "workspace:*", "@solana/codecs-strings": "workspace:*", diff --git a/packages/webcrypto-ed25519-polyfill/package.json b/packages/webcrypto-ed25519-polyfill/package.json index 06ceaba886d0..9c2cda347778 100644 --- a/packages/webcrypto-ed25519-polyfill/package.json +++ b/packages/webcrypto-ed25519-polyfill/package.json @@ -67,9 +67,6 @@ "supports bigint and not dead", "maintained node versions" ], - "engine": { - "node": ">=17.4" - }, "dependencies": { "@noble/ed25519": "^2.0.0" },