Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable eslint restrict-template-expressions plugin has a few extra linting errors #3694

Merged

Conversation

kox
Copy link

@kox kox commented Dec 8, 2024

While I was adding an extra eslint rule, I realized that there were a few extra linting errors from restrict-template-expressions rule.

One of them I had to comment it because when it gets stringified, it leaks relevant information. Probably it should be sanitized first.

Copy link

changeset-bot bot commented Dec 8, 2024

⚠️ No Changeset found

Latest commit: d9c37b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot added the community label Dec 8, 2024
@kox kox force-pushed the fix-eslint-restrict-template-expressions branch from a3288b5 to 855060a Compare December 9, 2024 22:27
@steveluscher steveluscher enabled auto-merge (squash) December 9, 2024 23:02
@steveluscher steveluscher force-pushed the fix-eslint-restrict-template-expressions branch from ce189cf to d9c37b3 Compare December 10, 2024 15:51
@steveluscher steveluscher merged commit 099c287 into solana-labs:master Dec 10, 2024
2 of 3 checks passed
@kox kox deleted the fix-eslint-restrict-template-expressions branch December 10, 2024 16:03
@kox
Copy link
Author

kox commented Dec 10, 2024

thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants