Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Gate: Timely vote credits #32857

Closed
AshwinSekar opened this issue Aug 16, 2023 · 3 comments · Fixed by anza-xyz/agave#3798
Closed

Feature Gate: Timely vote credits #32857

AshwinSekar opened this issue Aug 16, 2023 · 3 comments · Fixed by anza-xyz/agave#3798
Assignees
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@AshwinSekar
Copy link
Contributor

AshwinSekar commented Aug 16, 2023

Description

This will change the vote credit mechanism https://github.com/solana-foundation/solana-improvement-documents/blob/main/proposals/0033-timely-vote-credits.md, which will break consensus unless feature gated.

Additionally this will require community vote to approve.

Feature ID

2oXpeh141pPZCTCFHBsvCwG2BtaHZZAtrVhwaxSy6brS
tvcF6b1TRz353zKuhBjinZkKzjmihXmBAHJdjNYw1sQ

Activation Method

Staked Validator Vote

Deployment Considerations

Monitor vote credits upon activation.

Minimum Version

1.18.8

Testnet Activation Epoch

675

Devnet Activation Epoch

735

Mainnet-Beta Activation Epoch

703

@AshwinSekar AshwinSekar added the feature-gate Pull Request adds or modifies a runtime feature gate label Aug 16, 2023
@AshwinSekar AshwinSekar self-assigned this Aug 16, 2023
@buffalu
Copy link
Contributor

buffalu commented Oct 6, 2023

PLEASE LET ME KNOW BEFORE THIS SHIPS!!!!!!11!!1

This will break the currently deployed (as of October 5, 2023) version of the Jito Tip Distribution Program, which prevents Jito-Solana validators from operating correctly (not fatal to network, just a severe annoyance).

luckily my rebase just caught this as of commit 6f1922b in solana repo as we test tip distribution program functionality during CI

there are other jito programs that will likely be live that parse vote accounts on-chain as well that this will break, but those are less severe than this.

@AshwinSekar
Copy link
Contributor Author

definitely will do, i believe the feature you want to track is this one:
#31264

When turned on this will migrate old VoteState into the new format.

@AshwinSekar
Copy link
Contributor Author

rekeyed here anza-xyz#127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants