Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit the client apps to make sure that they behave sensibly when there is _no_ wallet installed #122

Open
5 of 7 tasks
steveluscher opened this issue Jul 18, 2022 · 1 comment
Open
5 of 7 tasks

Audit the client apps to make sure that they behave sensibly when there is _no_ wallet installed #122

steveluscher opened this issue Jul 18, 2022 · 1 comment
Assignees
@creativedrewy

Comments

@steveluscher
Copy link
Contributor

steveluscher commented Jul 18, 2022 •
edited
Loading

When there is no wallet installed (ie. nothing that responds to the Intent for association) all of our client apps and SDKs should do something sensible. That may include:

  • showing a message
  • throwing a custom error

Audit these apps to make sure that they do something sensible:

  • React Native sample app
  • Mobile web sample app
  • JavaScript protocol implementation
  • React Native native module protocol bridge
  • Ktx Sample dApp
  • RxJava Sample dApp
  • Fake dApp (as long as it is relevant)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@creativedrewy creativedrewy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveluscher @creativedrewy @sdlaver