Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find-value-in-files to return an empty string if no values found #224

Open
sfloess opened this issue Jul 10, 2016 · 1 comment
Open

Comments

@sfloess
Copy link
Member

sfloess commented Jul 10, 2016

Using find-value-in-files to locate test classes (or triggers) will yield a space when nothing is found. This is ugly later when deciding about running tests and computing how we build the runTask stanza (per #211). The following is what can be seen on the console to illustrate:

  • Test Classes: [TaskUtils_Test ]
  • Test Classes: [ ]
@sfloess
Copy link
Member Author

sfloess commented Jul 10, 2016

@pcon,

Will you be so kind as to test the fix in branch sfloess_issue-211? I've got a fix out and believe this works... I tested with both no changes to classes and a lone test class change. Fairly certain this is the correct fix.

Upon your ack, I will merge to master.

Thanks - and sorry this one took so long to resolve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant