Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with non-existing emails in migration #9

Open
michielbdejong opened this issue Nov 24, 2023 · 4 comments
Open

Deal with non-existing emails in migration #9

michielbdejong opened this issue Nov 24, 2023 · 4 comments

Comments

@michielbdejong
Copy link
Collaborator

No description provided.

@thhck
Copy link
Collaborator

thhck commented Nov 24, 2023

Should we use a email that we ( the solidcommunity.net administrator ) control instead of a virtual one used by NSS2CSS ?

@michielbdejong
Copy link
Collaborator Author

Although the expected arguments suggests that xxx acts as a template variable in [email protected], looking at how this argument is used it seems we can only use it as a way to define the value for emailDomain.

> '[email protected]'.replace(/.*@+/, '');
'users.css.pod'
> 'xxxusers.css.pod'.replace(/.*@+/, '');
'xxxusers.css.pod'
> '[email protected]@s.pod'.replace(/.*@/, '');
's.pod'
> 'solidcommunity.net'.replace(/.*@/, '');
'solidcommunity.net'
> 'any@[email protected]'.replace(/.*@/, '');
'solidcommunity.net'
> 'blackhole.solidcommunity.net'.replace(/.*@/, '');
'blackhole.solidcommunity.net'

So I suggest we set the emailPattern argument to blackhole.solidcommunity.net so that it's clear that these emails will not have mailboxes behind them in general.

And then I think there is a step missing from the migration script which we should probably add ourselves: to extract the real email address from the root /.acl file of each NSS pod, and use that as the email address for the CSS pod. Only if that process fails we can fall back to assigning an @blackhole.solidcommunity.net email address.

Here you see for instance that the email address for michielbdejong.solidcommunity.net is [email protected]:

Screenshot 2023-11-29 at 12 05 42

@bourgeoa
Copy link
Member

bourgeoa commented Nov 29, 2023

And then I think there is a step missing from the migration script which we should probably add ourselves: to extract the real email address from the root /.acl file of each NSS pod, and use that as the email address for the CSS pod. Only if that process fails we can fall back to assigning an @blackhole.solidcommunity.net email address.

I see 2 issues with the proposal to use root/.acl email :

  • some user may not remember the email they used on that userPod
  • on NSS you could use the same email on many pods. This is forbidden in CSS and create an error.

CSS v7 allows for multiple accounts (email/password) for the same pod.
A solution could be found around creating a second account with the NSS user email/password when the email was not already used.

So I suggest we set the emailPattern argument to blackhole.solidcommunity.net so that it's clear that these emails will not have mailboxes behind them in general.

Well. Why not, but being a fake emailDomain make it short.

@michielbdejong
Copy link
Collaborator Author

See also bourgeoa/NSS2CSS#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants