You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While dealing with this issue (solidjs/solid#1946), I came across such a problem that, for example, when using a structuredClone inside createUndoHistory It always makes call of source function
and do a clone of the object on undo and redo, even when it will never be used.
Maybe add a parameter where you can pass a signal that will track the changes like on function from reactive utilities?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
While dealing with this issue (solidjs/solid#1946), I came across such a problem that, for example, when using a
structuredClone
insidecreateUndoHistory
It always makes call of source functionsolid-primitives/packages/history/src/index.ts
Line 96 in 66feea6
and do a clone of the object on undo and redo, even when it will never be used.
Maybe add a parameter where you can pass a signal that will track the changes like
on
function from reactive utilities?Beta Was this translation helpful? Give feedback.
All reactions