Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occurrences of load instead ofpreload to router #963

Open
atilafassina opened this issue Nov 24, 2024 · 1 comment · May be fixed by #967
Open

Occurrences of load instead ofpreload to router #963

atilafassina opened this issue Nov 24, 2024 · 1 comment · May be fixed by #967
Labels
good first issue Good for newcomers help wanted Looking for assistance on this issue planned Features or content that are planned but not yet in progress. solid-router Related to Solid Router

Comments

@atilafassina
Copy link
Member

📚 Subject area/topic

Solid-Router, data-fetching, preloading

📋 Page(s) affected (or suggested, for new content)

TBD

📋 Description of content that is out-of-date or incorrect

It's been reported that some code snippets haven't been adapted to change of name.

Previously to preload date in a route, one would write:

export const route = {
  load: () => {...}
}

But recently the load key has been renamed to preload

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response

@atilafassina atilafassina added pending review Awaiting review by team members. solid-router Related to Solid Router labels Nov 24, 2024
@atilafassina atilafassina added good first issue Good for newcomers help wanted Looking for assistance on this issue planned Features or content that are planned but not yet in progress. and removed pending review Awaiting review by team members. labels Nov 24, 2024
@tentaShiratori
Copy link
Contributor

Thanks for the details! I'll start working on this issue. (By the way, I was using the name 白鳥 on Discord.)

@tentaShiratori tentaShiratori linked a pull request Nov 26, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Looking for assistance on this issue planned Features or content that are planned but not yet in progress. solid-router Related to Solid Router
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants