Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using mapper=None for binary_loads and parse raises a TypeError exception #3

Open
pickworthi opened this issue Oct 1, 2024 · 1 comment

Comments

@pickworthi
Copy link

I found this when using appcache.py from the steam repository. For it's function parse_appinfo, it uses the default parameter specification of mapper=None. When this is passed to binary_loads it causes the TypeError exception, since None is not a dict type.

I think it is common practice to use None as a default for 'no value given - use default' in Python.

I will submit a Pull Request that fixes this fairly trivial matter - makes the code a bit more robust.

@pickworthi
Copy link
Author

Submitted pull request: #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant