Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example from documentation doesn't work #70

Open
erezarnon opened this issue Jul 23, 2023 · 1 comment · May be fixed by #78
Open

Example from documentation doesn't work #70

erezarnon opened this issue Jul 23, 2023 · 1 comment · May be fixed by #78

Comments

@erezarnon
Copy link

erezarnon commented Jul 23, 2023

const redactor = new SyncRedactor({
  builtInRedactors: {
    names: {
      replaceWith: 'ANONYMOUS_PERSON'
    }
  }
});

redactor.redact('Dear David Johnson');

Expected: Dear ANONYMOUS_PERSON
Actual: Dear PERSON_NAME

Also, ideally we could pass in replaceWith: 'REDACTED__$3' which would allow to do some post-processing and keep track of what's being redacted.

const redactor = new SyncRedactor({
  builtInRedactors: {
    names: {
      replaceWith: 'REDACTED__$3'
    }
  }
});

redactor.redact('Dear David Johnson');

Expected: Dear REDACTED__David REDACTED__Johnson

@alvis
Copy link

alvis commented Oct 11, 2023

I've the same problem. Seems like exactly the same as #34 and fixed by #46

@pranaygp pranaygp linked a pull request Oct 20, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants