Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include information on your page that this is only meant for NodeJs. #77

Open
kenlnetherland opened this issue May 3, 2024 · 3 comments

Comments

@kenlnetherland
Copy link

kenlnetherland commented May 3, 2024

This may work in browsers if you install "tons" of polyfills. But this is not indended for browers as you advertise.

@dennybiasiolli
Copy link

@kenlnetherland is this text at the beginning of the README file not enough?

Prerequesites
This library is primarily written for node.js but it should work in the browser as well. It is written in TypeScript and compiles to ES2017. The library makes use of async functions and hence needs node.js 8.0.0 or higher (or a modern browser). If this is a problem for you please open an issue and we may consider adapting the compiler settings to support older node.js versions.

@kenlnetherland
Copy link
Author

Thanks for responding. I tried using it with Angular but kept getting errors with the npm packages that are strictly NodeJs packages. Your code may work, but the dependencies do not. My node version: v18.19.1

@angular-devkit/architect 0.1602.12
@angular-devkit/build-angular 16.2.12
@angular-devkit/core 16.2.12
@angular-devkit/schematics 16.2.12
@nguniversal/builders 16.2.0
@nguniversal/express-engine 16.2.0
@schematics/angular 16.2.12
ng-packagr 16.2.3
rxjs 7.5.0
typescript 4.9.5
zone.js 0.13.3

@dennybiasiolli
Copy link

Well, it works in our company Vue.js 2 project directly in the browser, but we forked the repo in order to remove the @google-cloud/dlp dependency that we are not using, and adding a couple of improvements.

Forked repo here: https://github.com/Fingerprint-Compliance/redact-pii
Changelog:

4.0.0 - 2021-09-09

  • BREAKING CHANGE: removing @google-cloud/dlp dependency
  • Improvement: adding lib directory to git, in order to use this library as is, in the compiled version
  • Fix: improving regex pattern including dashes in email domain addresses
  • Fix: improving url regex in href links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants