-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tar dependencies are unpacked to wrong directory #27
Comments
This caused me much grief over the last couple of days as well. Do you want a PR for this fix? |
There is #28, which seems to fix the problem. |
So for now we should use v1.0.2 |
FYI, Sonatype only lightly monitors issues here, I have created a parity issue on our JIRA and it's on our team radar. https://issues.sonatype.org/browse/NEXUS-19735 |
Hitting the same issue, forcing 1.0.2 seems to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a follow-up to #23, #24, #25 and #26. While extracting the .tgz dependencies no longer throws an error, the resulting files are probably extracted to the wrong directory. This might be caused by an API change between node-tar 2.x and 3.x where the parameter
path
of the formerExtract
method call was changed tocwd
of the newx
method call.See: https://www.npmjs.com/package/tar#tarxoptions-filelist-callback-alias-tarextract
While #26 changed the code to use
x
, the options passed to the method have not been adjusted. This probably leads to the dependencies to be extracted to the current working directory instead ofbower_components
. Inbower_components
there will be a directory for the dependency which contains nothing but a.bower.json
file.Please verify and possibly adjust the
tar.extract
method call to used thecwd
option.The text was updated successfully, but these errors were encountered: