Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying custom imagePullSecrets #44

Open
HaniAlshikh opened this issue Jan 8, 2024 · 3 comments
Open

Allow specifying custom imagePullSecrets #44

HaniAlshikh opened this issue Jan 8, 2024 · 3 comments

Comments

@HaniAlshikh
Copy link

HaniAlshikh commented Jan 8, 2024

Hi,

can you please explain the reasoning behind this:

- name: {{ template "nexus.name" . }}-imagepullsecret

As far as i can see there is no way to "manually" create {{ template "nexus.name" . }}-imagepullsecret without providing the credentials in plain text, since image-pull-secret.yam will be used as soon as an imagePullSecret is specificed

{{- if .Values.statefulset.imagePullSecrets }}

and the only way to provide the credentials is in plain text:

.dockerconfigjson: {{ .Values.statefulset.imagePullSecrets.secret }}

@HaniAlshikh
Copy link
Author

I created a PR to allow the usage of custom imagePullSecrets and kept the possibility of providing the credentials directly to avoid breaking changes.

Hope this can be reviewed and released soon, as it is a blocker for us and it prevents us from deploying Nexus RM.

@sylvaindd
Copy link

Hi, I manage my imagePullSecrets externally and could use this feature as well

@mpsOxygen
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants