[frr/bgpd] fix frr VXLAN EVPN configuration for unified config #21053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanblyschak
approved these changes
Dec 5, 2024
dgsudharsan
approved these changes
Dec 5, 2024
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
bradh352
force-pushed
the
frr-unified-evpn
branch
from
1b7d6ee to
5cb6d10
Compare
|
rebased to force rebuild to see if general sonic CI tests are working yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of
no fpm use-next-hop-groupswhich is forcibly set for all FRR instances.This change was introduced in PR #12852 when switching to the new fpm dataplane plugin.
When running
vtysh -c "config" -c "no fpm use-next-hop-groups"it can be seen the VTEP immediately comes online and traffic flows as expected.Work item tracking
How I did it
This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option.
How to verify it
See #21034 for details
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
master as of 20241205
Description for the changelog
[frr/bgpd] fix frr VXLAN EVPN configuration for unified config
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)
Fixes #21034
Signed-off-by: Brad House (@bradh352)