Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: new runs of test cases do not delete json file created #15864

Open
mgheorghe opened this issue Dec 4, 2024 · 1 comment
Open

[Bug]: new runs of test cases do not delete json file created #15864

mgheorghe opened this issue Dec 4, 2024 · 1 comment
Labels

Comments

@mgheorghe
Copy link
Contributor

Issue Description

Those files do not exist in github repo.
those files gets created without me running any test case in those folders

root@dash2:/home/...../sonic-mgmt# grep ./ -rn -e "cisco-8102-dut1"
grep: ./tests/_cache/vms-snappi-smartswitch/tbinfo.pickle: binary file matches
./tests/pfc_headroom_test_params/vms-snappi-smartswitch.json:3: "cisco-8102-dut1": {
./tests/priority/vms-snappi-smartswitch-lossy.json:3: "cisco-8102-dut1": []
./tests/priority/vms-snappi-smartswitch-all.json:3: "cisco-8102-dut1": []
./tests/priority/vms-snappi-smartswitch-lossless.json:3: "cisco-8102-dut1": []

Results you see

Those files do not exist in github repo.
those files gets created without me running any test case in those folders

root@dash2:/home/...../sonic-mgmt# grep ./ -rn -e "cisco-8102-dut1"
grep: ./tests/_cache/vms-snappi-smartswitch/tbinfo.pickle: binary file matches
./tests/pfc_headroom_test_params/vms-snappi-smartswitch.json:3: "cisco-8102-dut1": {
./tests/priority/vms-snappi-smartswitch-lossy.json:3: "cisco-8102-dut1": []
./tests/priority/vms-snappi-smartswitch-all.json:3: "cisco-8102-dut1": []
./tests/priority/vms-snappi-smartswitch-lossless.json:3: "cisco-8102-dut1": []

Results you expected to see

those files should be created only if tests is started and removed once test ends

Is it platform specific

generic

Relevant log output

NA

Output of show version

No response

Attach files (if any)

No response

@yxieca
Copy link
Collaborator

yxieca commented Dec 11, 2024

@sdszhang @wangxin for visibility

@selldinesh can you help take a look. My suggestions: if these files are cached information and can be used in next test without change, then they should go to the cache folder. Otherwise, cleanup is preferred.

@yxieca yxieca added the Triaged label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants