[test gap] Add a new test case to verify lldp entry after restart syncd and orchagent #15911
+52
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cd and orchagent Signed-off-by: Zhaohui Sun <[email protected]>
ZhaohuiS
changed the title
Signed-off-by: Zhaohui Sun <[email protected]>
Signed-off-by: Zhaohui Sun <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
|
Hold on the merge until sonic-net/sonic-buildimage#21065 is merged, which is the image fix. |
|
@StormLiangMS Since image fix was merged in sonic-net/sonic-buildimage#21065, could you please review and approve this test gap PR? |
| lldp_entry_keys, show_lldp_table_int_list, lldpctl_interfaces | ||
| ) | ||
| for interface in get_lldp_entry_keys(db_instance): | ||
| entry_content = get_lldp_entry_content(db_instance, interface) |
There was a problem hiding this comment.
This seems repeating code in this file, could we move them into a function? Too much code and logic inside this test to make it hard to read through, and distracting from the main function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cd and orchagent
Description of PR
Summary:
Fixes # (issue)
Address #15889
Type of change
Back port request
Approach
What is the motivation for this PR?
Add a new test case to address #15889
How did you do it?
Restart syncd and orchagent, then check lldp entries in APPL_DB
How did you verify/test it?
run test_lldp_syncd.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation