-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add word status #347
Merged
Merged
Add word status #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonic16x
requested review from
noomorph and
ru-danko
and removed request for
noomorph
November 24, 2024 16:45
sonic16x
force-pushed
the
feat/word-status
branch
from
November 25, 2024 15:51
8684cb9
to
4491b95
Compare
ru-danko
approved these changes
Nov 25, 2024
noomorph
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have my 🦭 of approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes to the codebase, focusing on improving the handling of word statuses, updating themes and colors, and refining some component functionalities.
Improvements to word status handling:
src/components/Modals/TranslationsModal/TranslationsModal.tsx
: AddedgetWordStatus
utility to display word status in the modal dialog. [1] [2] [3]src/components/ResultsCard/ResultsCard.tsx
: IntroducedWordStatus
component to handle word status display and improved the handling of word IDs and statuses. [1] [2] [3] [4] [5] [6]src/services/dictionary.ts
: Added new fields (id
,new
,intelligibility
,remove
) toITranslateResult
interface and updated methods to handle these new fields. [1] [2] [3] [4] [5] [6]Theme and color updates:
src/colors.scss
: Updated the color scheme for tips background and table highlighted cells. [1] [2]src/components/Tips/Tips.scss
: Changed the font color for tips to use the--light
variable.Component functionality refinements:
src/components/Main/Main.tsx
: Simplified the theme application logic and improved the asynchronous data fetching process.src/components/Pages/CommunityPage/CommunityPage.tsx
: Removed unnecessary state management for Facebook availability and streamlined the community links rendering logic. [1] [2] [3]Miscellaneous updates:
package.json
: Updated pre-commit hooks to uselint:fix
andstylelint:fix
.src/index.tsx
: Restricted service worker registration to production environment only.These changes collectively aim to enhance the user experience, improve code maintainability, and ensure better handling of word statuses across the application.