Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add word status #347

Merged
merged 11 commits into from
Nov 25, 2024
Merged

Add word status #347

merged 11 commits into from
Nov 25, 2024

Conversation

sonic16x
Copy link
Owner

@sonic16x sonic16x commented Nov 24, 2024

This pull request includes various changes to the codebase, focusing on improving the handling of word statuses, updating themes and colors, and refining some component functionalities.

Improvements to word status handling:

Theme and color updates:

Component functionality refinements:

Miscellaneous updates:

  • package.json: Updated pre-commit hooks to use lint:fix and stylelint:fix.
  • src/index.tsx: Restricted service worker registration to production environment only.

These changes collectively aim to enhance the user experience, improve code maintainability, and ensure better handling of word statuses across the application.

@coveralls
Copy link

coveralls commented Nov 24, 2024

Pull Request Test Coverage Report for Build 12013775761

Details

  • 1 of 93 (1.08%) changed or added relevant lines in 12 files are covered.
  • 27 unchanged lines in 22 files lost coverage.
  • Overall coverage increased (+0.1%) to 6.123%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.tsx 0 1 0.0%
src/services/dictionary-test/index.ts 0 1 0.0%
src/utils/getWordStatus/index.ts 0 1 0.0%
src/components/Modals/TranslationsModal/TranslationsModal.tsx 0 2 0.0%
src/components/Pages/CommunityPage/CommunityPage.tsx 0 3 0.0%
src/components/Main/Main.tsx 0 4 0.0%
src/components/ResultsCard/ResultsCard.tsx 0 5 0.0%
src/services/dictionary.ts 0 6 0.0%
src/utils/getWordStatus/getWordStatus.ts 0 9 0.0%
src/services/dictionary-test/dictionary-test.ts 0 27 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/Expand/Expand.tsx 1 0.0%
src/components/LineSelector/LineSelector.tsx 1 0.0%
src/utils/getTablePublicUrl/getTablePublicUrl.ts 1 0.0%
src/index.tsx 1 0.0%
src/components/Results/Results.tsx 1 0.0%
src/components/Spinner/Spinner.tsx 1 0.0%
src/components/Pages/DictionaryPage/DictionaryPage.tsx 1 0.0%
src/components/Card/Card.tsx 1 0.0%
src/components/Text/Text.tsx 1 0.0%
src/components/Pages/Viewer/ViewerPOSFilterComponent.tsx 1 0.0%
Totals Coverage Status
Change from base Build 11990483180: 0.1%
Covered Lines: 162
Relevant Lines: 2952

💛 - Coveralls

@sonic16x sonic16x requested review from noomorph and ru-danko and removed request for noomorph November 24, 2024 16:45
@sonic16x sonic16x self-assigned this Nov 24, 2024
@sonic16x sonic16x added the feature New functionality label Nov 24, 2024
Copy link
Collaborator

@noomorph noomorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my 🦭 of approval

@sonic16x sonic16x merged commit 24628e3 into master Nov 25, 2024
6 checks passed
@sonic16x sonic16x deleted the feat/word-status branch November 25, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants