Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if steam is installed #1058

Closed
Mte90 opened this issue Mar 15, 2024 · 1 comment · Fixed by #1059
Closed

Check if steam is installed #1058

Mte90 opened this issue Mar 15, 2024 · 1 comment · Fixed by #1059
Labels
enhancement New feature or request

Comments

@Mte90
Copy link
Contributor

Mte90 commented Mar 15, 2024

So right now executing STL without steam you get this:

ven 15 mar 2024, 11:56:37, CET WARN - setSteamPaths - Steam 'userdata' directory not found, other variables depend on it - Expect problems
grep: : File o directory non esistente
grep: : File o directory non esistente
ven 15 mar 2024, 11:56:38, CET ERROR - checkIntDeps - '' was not found! Check 'steamtinkerlaunch --help' for alternatives and/or read 'https://github.com/sonic2kk/steamtinkerlaunch/wiki/Yad'
ven 15 mar 2024, 11:56:38, CET ERROR - checkIntDeps - Yad version '0' is too old. You need to update to at least '7.2'

So I think that the tool should check if the steam binary exists, also in my case I don't have yad but is still reporting a version.

@Mte90 Mte90 added the bug Something isn't working label Mar 15, 2024
@sonic2kk sonic2kk added enhancement New feature or request and removed bug Something isn't working labels Mar 15, 2024
@sonic2kk
Copy link
Owner

sonic2kk commented Mar 15, 2024

I noted this on the PR but just for continuity of anyone reading this, we will only do this if we're not running Steam Flatpak (INFLATPAK -eq 0).

also in my case I don't have yad but is still reporting a version.

It's giving 0 which is invalid, so this is fine imo. But also as noted on #1059, we could have improved logging for missing Yad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants