-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no wait requester but to locale issues either #1138
Comments
You should be using SteamTinkerLaunch from master, as v12.12 is over a year out-of-date. The issue template also asked you to test master before opening an issue. So please update first and then try again. You'll need to provide a log file. A log is not equivalent to the commandline output in this context. A couple of things to note:
|
Something else:
Was this disabled this by default? You should not normally have to do this. Check to make sure there is no file to disable the wait requester in, for example, You should also check to make sure the timeout for the Wait Requester was not set to It would also be interesting to know if this happens with any other game, and a log file from this game and any other game you try would be useful. |
i installed steam tinker launch from git andi can access game setting via the settings cli option however the wait requester is stilla no show. /dev/shm/steamtinkerlaunch doesnt exists wait editor is set to 2 in the title config i ran steamtinkerlaunch wr e restarted the game and it didnt work the wait requester apeard when running henry stickmin but no jedi survivor |
how do i get the logs from the game launch as i cant see it anywhere in the troubleshooting guide |
Information on where to find the log is on the Readme and on the issue template where it asked you to provide a log. I'm not sure how If this issue is specific to Jedi Survivor, a log would be extra helpful here. To make sure, are you using SteamTinkerLaunch as a compatibility tool for Jedi Survivor? There have been oddities reported before that were a result of trying to use the Launch Option (which is only for native games) with Proton games. |
Jedi Survivor.log i looked in /dev/shm/steamtinkerlaunch again and there was a log file amongst other things
|
Thanks for the log. In future, please attach logs as files to GitHub. From initial inspection I can see the Main Menu is being skipped but it is not obvious why. Out of interest do you have any other games that use the EA App and do they skip the Wait Requester? I have some which I will download to test this out as well. This could be specific to some weirdness that EA App games could be doing, I guess we will see. |
Sorry about the log and I have the original jedi game which is also made by ea but it will take a while to install I can start it now and check in the morning |
Couldn't reproduce the issue with Mass Effect Legendary Edition or (a classic SteamTinkerLaunch EA-troubleshooting game) Unravel. The Wait Requester shows up fine. I don't own Jedi Survivor so I can't test that. However, are you absolutely sure this isn't potentially a locale issue? You mentioned already that you explored this path, but bring it up because I noticed the game title from your log has the trademark symbol, "STAR WARS Jedi: Survivor™ (1774580)". Does this symbol display properly if you run Better yet, do you have any other games with trademark symbols or other similar symbols in their name? You can search your library for |
when running steam tinker launch settings the tm symbol does show up and the only error i see is a grid file not existing but the menu still shows up my laptop syspended so once fallen order is installed (its by ea and has the tm symbol) ill test that as well |
Very odd for sure. It's strange that this one game is not showing the Wait Requester. Perhaps it's some oddity with this single game. I cannot recreate the problem... |
wait register works on fallen order so idk why survior isnt working its littraly the next game in the series |
It seems like there is something wrong specific to Jedi Survivor. This is two games now that work. When you launch Jedi Survivor, in |
none of those files exist |
From looking at your log, the Wait Requester code is called right after this log line: https://github.com/sonic2kk/steamtinkerlaunch/blob/144347b1c1b322bda8d3cdc5559ad284a9f8578c/steamtinkerlaunch#L10721 But then it goes direectly into this line: https://github.com/sonic2kk/steamtinkerlaunch/blob/144347b1c1b322bda8d3cdc5559ad284a9f8578c/steamtinkerlaunch#L19100 Which is called directly after the Wait Requester exits. So the relevant code for the Wait Requester is here: https://github.com/sonic2kk/steamtinkerlaunch/blob/144347b1c1b322bda8d3cdc5559ad284a9f8578c/steamtinkerlaunch#L10721-L10745 It seems for some reason the Wait Requester exits without any codes matching the I will push a commit that logs the result of the Wait Requester so that we can see what it is returning here for you. In the meantime, if you launch Steam from the commandline, it would be helpful if you could check to see if there are any potential errors coming from Yad, such as a segfault when trying to show the Wait Requester. You can check this by running I am not sure yet if we should default to showing the Main Menu if the Wait Requester fails. I think this is probably a safe enough option but I will have to test it a bit locally first. Once the new commit is pushed I'll update you and you can re-pull from master and send through a new log from an attempted launch of Jedi Survivor. |
You can update from master and attach a new log now, b48b32f has some additional logging for what code the Wait Requester returns and a fallback case to open the Main Menu if the Wait Requester returns an unknown code. Please update and try running again. You may even get to the Main Menu this time but if you can attach a log I would appreciate that as well to get a look at what exit code the Wait Requester is returning. Or if there is something very seriously failing, the Wait Requester failing may be crashing SteamTinkerLaunch entirely (if your game starts, I think this is unlikely). Your log doesn't have any logging for whatever it's trying to do. It does not even log that it opens the Main Menu, so it likely isn't hitting the line for exit code |
Was the logging the only change in the commit? |
steam.log |
Logging and a version bump were changed, then a catch was put in to show the Main Menu if we get an unknown exit code from Yad: b48b32f However that would not impact the Wait Requester appearing, it would cause the Main Menu to show up, so I don't think that had an impact. The only other relevant change I can think of is, a variable was also used to track the exit code (so that we can log it in each match of the That's interesting that the Wait Requester worked though. I'll take a peak at the logs and see what's up. |
if you don't run Steam from the commandline, does this work? I assume you tested with Steam running from the commandline to get the Steam log but maybe you already tested. It's unusual but there is sometimes different behaviour with Steam running from a shell prompt (I had to do this for a while during the initial recent Client Beta to get the Steam Overlay to work). If you tested and the Wait Requester works when not running Steam from the commandline as well, then I guess this issue is fixed somehow 😅 |
omfg it didn't show up |
Dammit, I had a feeling 😓 I'm skimming the log on my phone right now and I found these lines:
Seems like my hunch was right -- We're getting an exit code here that we shouldn't be. For some reason Yad is giving an exit code of Thank you for your patience here, this is very unusual so I'm glad you stuck with me and provided good logs :-)
That's a great question. There are logs somewhere in |
I tested the image that SteamTinkerLaunch probably downloaded for Jedi Survivor from Steam from this link and it was able to display properly in Yad. If the This also would not really explain why things work outside of Steam but break inside of Steam. This is a very odd case that I have not seen before for the Wait Requester... |
I don't get what steam is doing differently when running cli Vs headless. That's what's really confusing me like what is it doing differently to cause that? Do we know it's a bad file or is that just a guess? |
A bad file is a complete guess. I fully agree, maybe there is something coming from the environment when you're running Steam that gets it to run properly. I have had this happen where I need to run Steam from the commandline for a while to get certain features to work properly, like controller support (a long time ago) or the Steam Overlay (the initial release of the June 2024 Steam Client Beta). So it's not completely unheard of that Steam behaviour can change when running from the commandline, but that's historically for me been for Steam-specific features and not third-party tools. I have also never experienced this kind of discrepancy with SteamTinkerLaunch. I don't think reinstalling the game would fix much, I think this is some environment issue. Whether it's a bug on Steam's side or a bug on the SteamTinkerLaunch side, I'm not sure. Here's something else to try, if you have any other games marked as Steam Deck Unsupported, try those from Steam headless to see if they work. The reason for this is that the two games which worked were Steam Deck Playable (Jedi Fallen Order) and Steam Deck Verified (Henry Stickman). The Steam Deck compatibility information is displayed on the Wait Requester and the Main Menu, but the way they are displayed is different, so perhaps for some reason Steam can't properly parse the "Unsupported" symbol ( Unfortunately while you can filter your library by Steam Deck compatibility, you cannot filter by Unsupported only. You can enable Steam Deck Compatibility information from the Steam Client Settings -> Library -> "Show Steam Deck compatibility information in library". Then you can click on the info button on a game page to view the compatibility information underneath its description and Steam feature info. I guess I should ask just to be extra: With the most recent commit, even when running Steam headless, does Jedi Survivor make it to the Main Menu now? Since we should be falling back to the Main Menu. Looking at the log it looks like it does, just want to confirm this to know if the "Unsupported" symbol can display on the Main Menu when running Jedi Survivor from Steam. |
aim labs unsupported by steam shows wait requester when running steam headless (white box icon) |
Even after the latest commit? Huh, I guess the Main Menu is failing with its Yad command too. There is something incompatible with this game then it seems that breaks both the Wait Requester and the Main Menu. I would wager this affects all Yad windows, and I would also wager the Main Menu is returning On that, I did a bit of digging but could not find So there is something causing Yad to error out with Still an absolute shot in the dark but did you find anything wrong with the image the command is trying to use? The one at |
The image shows in the main menu when I open it via settings and I can open the image in other apps |
The header image won't be re-downloaded if you run Does the Wait Requester work from Steam headless now that the image has been deleted? |
no the wait requester is still a no show after running headless |
wtf steam now isnt running survivor at all no gamescope no gmemode no tinker launch wtf yesterday i was able to play it using running steam in gamescope with proton experimental and now that same setup isnt working. its get to the ea app "preparing game" once that closes it indefinatly hangs how do i run a steam game outside of steam (with proton )so i can check what its actually doing i reset steam runtime with no change? what changed compared to when i last ran experimental? |
Do you mean Steam isn't launching the game at all, just vanilla, no SteamTinkerLaunch or any other tools? Also, are you running the Steam Client inside of GameScope, or do you mean you're passing
I would first check a restart to make sure this isn't a lingering Wineserver process preventing games from running. This happens to me all of the time. A reboot is the quickest way usually to clear all of the processes. (Side Note: You probably don't have to do this - You can just pass Onto the question: I don't believe this will actually work, because of DRM. When you run a Steam Game, native or with Proton, it will either:
Jedi Survivor, and other EA games, are an odd case, because they do not actually launch an executable. Instead, Proton gets passed a When you press "Play" from Steam, this is the exact command that Proton gets. This is what launches the app from the EA app installed in the Proton prefix, where With all that out of the way, to build the Proton command that Steam uses manually, you need the following. If you're curious, most of this information is also logged in the SteamTinkerLaunch log file.
Putting all that together, your command might look something like this:
TL;DR - The command above would be the way, but it may fail, because DRM.
Did Experimental update in the background? The last version you were using was Valve Proton versions will sometimes update even if there is no changelog update. For Valve Proton versions this is denoted with a letter at the end of the version, i.e. Also I am not sure what you mean by you "reset steam runtime". Did you reinstall Steam, or are you referring to the Steam Linux Runtime? Sorry, just a bit confused. |
The EA app opens the closes/hidden to start the game (it shows a small screen saying preparing game) after that disappears it will hang forever and not load the game no audio no visual I mean running steam inside gamescope e.g |
i ended up reinstalling the game and it now works. Back to testing steam tinker launch. Unfortunately i have no idea why it broke in the firstplace though |
That was odd that it stopped working but at least the failure to launch wasn't isolated to SteamTinkerLaunch. Maybe the EA app borked itself during an update, I'm not sure 😅
One thing I meant to mention was that if you're ever curious you can see the "final outgoing" start command in the SteamTinkerLaunch log. This is basically the start command with the Steam Linux Runtime, Proton script path+verb, and game start executable coming from Steam, but also includes any arguments or third-party tool paths (like GameScope). The only things of doesn't include in that string are the environment variables for things like the Steam compatdata path, but these variables are logged in the SteamTinkerLaunch log (except for her Steam Client install path, which I should probably add). There may be a debug vars file in the I wonder if it would be worthwhile adding another log with the outgoing start command for the "full" command you can use to launch the game outside of Steam for debugging purposes. |
Were you able to dig into this any more, or reproduce the problem with other games? I have still not been able to replicate the problem. The issue seems to be that Yad is failing to run, so the exit code that SteamTinkerLaunch looks for from the command is not an expected value. Each button along the bottom will produce an exit code, as a "response" code for whatever button was pressed. But it seems that Yad is producing an error code |
No every other game I try has worked with STL and I'm now away with family so I don't have time for testing games. |
System Information
Issue Description
i get a notification steam tinker launch has started and the game (jedi surivior) run but i get to wait requester
i just installed stl and i have enabled wait request using the cli option as well
Logs
cli ouput is fine and no locale issues this is my first time using steam tinker launch
The text was updated successfully, but these errors were encountered: