[video_player] Add support GstEGLImage to improve playback performance #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makotosato-at
force-pushed
the
eglimage_support
branch
from
0def421
to
ae6f049
Compare
|
I agree to delegate all rights related to this PR to Sony. |
There was a problem hiding this comment.
Please update the following files, too:
- AUTHORS
- CHANGELOG.md
- README.md if needed
- pubspec.yaml
| #ifdef USE_EGL_IMAGE_DMABUF | ||
| gboolean res = gst_video_info_from_caps(&gstVideoInfo_, caps); | ||
| if (!res) { | ||
| std::cerr << "Failed to get a gst_video_info"; |
There was a problem hiding this comment.
Add std::endl
Comment on lines
88
to
91
| GstVideoInfo gstVideoInfo_; | ||
| GstEGLImage* gsteglimage_ = NULL; | ||
| GstGLContext* gstglctx_ = NULL; | ||
| GstGLDisplayEGL* gldisplayegl_ = NULL; |
There was a problem hiding this comment.
Please follow Google's coding style.
e.g.
gstVideoInfo_ -> gst_video_info_
|
|
||
| gint fd = gst_dmabuf_memory_get_fd(memory); | ||
| gldisplayegl_ = | ||
| gst_gl_display_egl_new_with_egl_display((gpointer)egl_display); |
There was a problem hiding this comment.
Use static_cast
| gldisplayegl_ = | ||
| gst_gl_display_egl_new_with_egl_display((gpointer)egl_display); | ||
| gstglctx_ = gst_gl_context_new_wrapped( | ||
| GST_GL_DISPLAY_CAST(gldisplayegl_), (guintptr)egl_context, |
Signed-off-by: Makoto Sato <[email protected]>
makotosato-at
force-pushed
the
eglimage_support
branch
from
ae6f049
to
761c957
Compare
|
I fixed code. |
HidenoriMatsubayashi
approved these changes
Feb 10, 2023
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I added
GstEGLImagesupport to improve video_player playback performance.If gst_is_
dmabuf_memory()isTRUE,GstEGLImagecan be used to improve performance withoutgst_buffer_extract().Relevant issue: #64
This requires the following PR:
sony/flutter-embedded-linux#327
and the option -DUSE_EGL_IMAGE_DMABUF is required at build time.