From 9f11bb249f9e809d0789c37fdf202dff648f865a Mon Sep 17 00:00:00 2001 From: jonathan-r-thorpe Date: Mon, 7 Oct 2024 17:22:34 +0100 Subject: [PATCH 1/3] Version up download-artifact and upload-artifact --- .github/workflows/build-test.yml | 10 +++++----- .github/workflows/src/build-test.yml | 2 +- .github/workflows/src/save-results.yml | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index e5a813a87..2296bf80c 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -587,12 +587,12 @@ jobs: export SHEET=https://docs.google.com/spreadsheets/d/${{ env.SECRET_RESULTS_SHEET_ID }} python nmos-testing/utilities/run-test-suites/gsheetsImport/resultsImporter.py --credentials ${{ env.GDRIVE_CREDENTIALS }} --sheet "$SHEET" --insert --json nmos-testing/results/${{ env.GITHUB_COMMIT }}-*.json || echo "upload failed" - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4.4.1 with: name: ${{ env.BUILD_NAME }}_badges path: ${{ runner.workspace }}/nmos-testing/badges - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4.4.1 with: name: ${{ env.BUILD_NAME }}_results path: ${{ runner.workspace }}/nmos-testing/results @@ -1145,12 +1145,12 @@ jobs: export SHEET=https://docs.google.com/spreadsheets/d/${{ env.SECRET_RESULTS_SHEET_ID }} python nmos-testing/utilities/run-test-suites/gsheetsImport/resultsImporter.py --credentials ${{ env.GDRIVE_CREDENTIALS }} --sheet "$SHEET" --insert --json nmos-testing/results/${{ env.GITHUB_COMMIT }}-*.json || echo "upload failed" - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4.4.1 with: name: ${{ env.BUILD_NAME }}_badges path: ${{ runner.workspace }}/nmos-testing/badges - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4.4.1 with: name: ${{ env.BUILD_NAME }}_results path: ${{ runner.workspace }}/nmos-testing/results @@ -1171,7 +1171,7 @@ jobs: echo "GITHUB_WORKSPACE=${{ github.workspace }}" >> $GITHUB_ENV echo "RUNNER_WORKSPACE=${{ runner.workspace }}" >> $GITHUB_ENV - - uses: actions/download-artifact@v2.0 + - uses: actions/download-artifact@v4.1.8 with: path: ${{ runner.workspace }}/artifacts diff --git a/.github/workflows/src/build-test.yml b/.github/workflows/src/build-test.yml index 76a224270..2afcb95a1 100644 --- a/.github/workflows/src/build-test.yml +++ b/.github/workflows/src/build-test.yml @@ -199,7 +199,7 @@ jobs: echo "GITHUB_WORKSPACE=${{ github.workspace }}" >> $GITHUB_ENV echo "RUNNER_WORKSPACE=${{ runner.workspace }}" >> $GITHUB_ENV - - uses: actions/download-artifact@v2.0 + - uses: actions/download-artifact@v4.1.8 with: path: ${{ runner.workspace }}/artifacts diff --git a/.github/workflows/src/save-results.yml b/.github/workflows/src/save-results.yml index fc04cd259..346e88c7e 100644 --- a/.github/workflows/src/save-results.yml +++ b/.github/workflows/src/save-results.yml @@ -6,12 +6,12 @@ export SHEET=https://docs.google.com/spreadsheets/d/${{ env.SECRET_RESULTS_SHEET_ID }} python nmos-testing/utilities/run-test-suites/gsheetsImport/resultsImporter.py --credentials ${{ env.GDRIVE_CREDENTIALS }} --sheet "$SHEET" --insert --json nmos-testing/results/${{ env.GITHUB_COMMIT }}-*.json || echo "upload failed" -- uses: actions/upload-artifact@v1 +- uses: actions/upload-artifact@v4.4.1 with: name: ${{ env.BUILD_NAME }}_badges path: ${{ runner.workspace }}/nmos-testing/badges -- uses: actions/upload-artifact@v1 +- uses: actions/upload-artifact@v4.4.1 with: name: ${{ env.BUILD_NAME }}_results path: ${{ runner.workspace }}/nmos-testing/results From 65d8054b2dee650545aaf4d4647b11a8f5e88848 Mon Sep 17 00:00:00 2001 From: "Jonathan Thorpe (Sony)" Date: Tue, 8 Oct 2024 14:35:14 +0100 Subject: [PATCH 2/3] v4.4.1 of upload-artifact uses Node20 which is incompatible with "out of the box" Ubuntu 14.04. Downgrading to v3.0.2 --- .github/workflows/build-test.yml | 8 ++++---- .github/workflows/src/save-results.yml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 2296bf80c..570bbac68 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -587,12 +587,12 @@ jobs: export SHEET=https://docs.google.com/spreadsheets/d/${{ env.SECRET_RESULTS_SHEET_ID }} python nmos-testing/utilities/run-test-suites/gsheetsImport/resultsImporter.py --credentials ${{ env.GDRIVE_CREDENTIALS }} --sheet "$SHEET" --insert --json nmos-testing/results/${{ env.GITHUB_COMMIT }}-*.json || echo "upload failed" - - uses: actions/upload-artifact@v4.4.1 + - uses: actions/upload-artifact@v3.0.2 with: name: ${{ env.BUILD_NAME }}_badges path: ${{ runner.workspace }}/nmos-testing/badges - - uses: actions/upload-artifact@v4.4.1 + - uses: actions/upload-artifact@v3.0.2 with: name: ${{ env.BUILD_NAME }}_results path: ${{ runner.workspace }}/nmos-testing/results @@ -1145,12 +1145,12 @@ jobs: export SHEET=https://docs.google.com/spreadsheets/d/${{ env.SECRET_RESULTS_SHEET_ID }} python nmos-testing/utilities/run-test-suites/gsheetsImport/resultsImporter.py --credentials ${{ env.GDRIVE_CREDENTIALS }} --sheet "$SHEET" --insert --json nmos-testing/results/${{ env.GITHUB_COMMIT }}-*.json || echo "upload failed" - - uses: actions/upload-artifact@v4.4.1 + - uses: actions/upload-artifact@v3.0.2 with: name: ${{ env.BUILD_NAME }}_badges path: ${{ runner.workspace }}/nmos-testing/badges - - uses: actions/upload-artifact@v4.4.1 + - uses: actions/upload-artifact@v3.0.2 with: name: ${{ env.BUILD_NAME }}_results path: ${{ runner.workspace }}/nmos-testing/results diff --git a/.github/workflows/src/save-results.yml b/.github/workflows/src/save-results.yml index 346e88c7e..13a55ac46 100644 --- a/.github/workflows/src/save-results.yml +++ b/.github/workflows/src/save-results.yml @@ -6,12 +6,12 @@ export SHEET=https://docs.google.com/spreadsheets/d/${{ env.SECRET_RESULTS_SHEET_ID }} python nmos-testing/utilities/run-test-suites/gsheetsImport/resultsImporter.py --credentials ${{ env.GDRIVE_CREDENTIALS }} --sheet "$SHEET" --insert --json nmos-testing/results/${{ env.GITHUB_COMMIT }}-*.json || echo "upload failed" -- uses: actions/upload-artifact@v4.4.1 +- uses: actions/upload-artifact@v3.0.2 with: name: ${{ env.BUILD_NAME }}_badges path: ${{ runner.workspace }}/nmos-testing/badges -- uses: actions/upload-artifact@v4.4.1 +- uses: actions/upload-artifact@v3.0.2 with: name: ${{ env.BUILD_NAME }}_results path: ${{ runner.workspace }}/nmos-testing/results From f7276306ad73a5fb3997844dfd52e421307384ca Mon Sep 17 00:00:00 2001 From: "Jonathan Thorpe (Sony)" Date: Tue, 8 Oct 2024 14:49:21 +0100 Subject: [PATCH 3/3] Downgrade upload-artifact version --- .github/workflows/build-test.yml | 8 ++++---- .github/workflows/src/save-results.yml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 570bbac68..5bbdb9cb0 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -587,12 +587,12 @@ jobs: export SHEET=https://docs.google.com/spreadsheets/d/${{ env.SECRET_RESULTS_SHEET_ID }} python nmos-testing/utilities/run-test-suites/gsheetsImport/resultsImporter.py --credentials ${{ env.GDRIVE_CREDENTIALS }} --sheet "$SHEET" --insert --json nmos-testing/results/${{ env.GITHUB_COMMIT }}-*.json || echo "upload failed" - - uses: actions/upload-artifact@v3.0.2 + - uses: actions/upload-artifact@v3.0.0 with: name: ${{ env.BUILD_NAME }}_badges path: ${{ runner.workspace }}/nmos-testing/badges - - uses: actions/upload-artifact@v3.0.2 + - uses: actions/upload-artifact@v3.0.0 with: name: ${{ env.BUILD_NAME }}_results path: ${{ runner.workspace }}/nmos-testing/results @@ -1145,12 +1145,12 @@ jobs: export SHEET=https://docs.google.com/spreadsheets/d/${{ env.SECRET_RESULTS_SHEET_ID }} python nmos-testing/utilities/run-test-suites/gsheetsImport/resultsImporter.py --credentials ${{ env.GDRIVE_CREDENTIALS }} --sheet "$SHEET" --insert --json nmos-testing/results/${{ env.GITHUB_COMMIT }}-*.json || echo "upload failed" - - uses: actions/upload-artifact@v3.0.2 + - uses: actions/upload-artifact@v3.0.0 with: name: ${{ env.BUILD_NAME }}_badges path: ${{ runner.workspace }}/nmos-testing/badges - - uses: actions/upload-artifact@v3.0.2 + - uses: actions/upload-artifact@v3.0.0 with: name: ${{ env.BUILD_NAME }}_results path: ${{ runner.workspace }}/nmos-testing/results diff --git a/.github/workflows/src/save-results.yml b/.github/workflows/src/save-results.yml index 13a55ac46..89e5c414b 100644 --- a/.github/workflows/src/save-results.yml +++ b/.github/workflows/src/save-results.yml @@ -6,12 +6,12 @@ export SHEET=https://docs.google.com/spreadsheets/d/${{ env.SECRET_RESULTS_SHEET_ID }} python nmos-testing/utilities/run-test-suites/gsheetsImport/resultsImporter.py --credentials ${{ env.GDRIVE_CREDENTIALS }} --sheet "$SHEET" --insert --json nmos-testing/results/${{ env.GITHUB_COMMIT }}-*.json || echo "upload failed" -- uses: actions/upload-artifact@v3.0.2 +- uses: actions/upload-artifact@v3.0.0 with: name: ${{ env.BUILD_NAME }}_badges path: ${{ runner.workspace }}/nmos-testing/badges -- uses: actions/upload-artifact@v3.0.2 +- uses: actions/upload-artifact@v3.0.0 with: name: ${{ env.BUILD_NAME }}_results path: ${{ runner.workspace }}/nmos-testing/results