Fixed director readiness probe failing whend using BASE_PATH env #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbritoferreira
previously approved these changes
Oct 2, 2023
auto-merge was automatically disabled
October 10, 2023 17:47
Head branch was pushed to by a user without write access
Readiness probe was failing when using BASE_PATH env
shkuviak
force-pushed
the
fix/director_base_path
branch
from
2bf1948 to
45e4c3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting
BASE_PATHenv variable to serve director from subpath (ex: reverse proxy to http://myhostname/cypress/dashboard), readiness probe was failing.Current behavior
Director health check was listening on
/my/base/path/health-check-dbwhile health check was made against/heath-check-dbExpected behavior
Health-check should run against
/my/base/path/health-check-dbwhen BASE_PATH is set.Checklist: