Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Batch Changes: Approved Status #6784

Open
johnwesonga opened this issue Apr 19, 2023 · 0 comments
Open

Batch Changes: Approved Status #6784

johnwesonga opened this issue Apr 19, 2023 · 0 comments

Comments

@johnwesonga
Copy link
Contributor

Chime has noticed that batch changes appear as approved in the UI when they are not able to be merged. This is b/c they have some weird code review requirements. Basically, for some repos the code has to be reviewed by the code owner. Someone else could approve review the PR but it cannot be merged until the code owner approves it.

Basically, while the PR is marked as review required in GitHub, it should not show up as approved in the batch changes UI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant