grpc: RepoList: actually persist "repos" field when converting to protobuf message #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggilmore
force-pushed
the
fix-grpc-repos
branch
from
b71c723
to
755f4cf
Compare
ggilmore
force-pushed
the
fix-grpc-repos
branch
from
755f4cf
to
fbac5a8
Compare
ggilmore
changed the title
eseliger
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/sourcegraph/sourcegraph/issues/56342
The repos field wasn't actually propagated properly to the protobuf message - it was hardcoded to an empty slice.
This PR also adds a fuzz test to catch this error. I needed to use https://github.com/AdaLogics/go-fuzz-headers for this since neither go 1.18 fuzzing (no struct support) or quick/check (no support for unexported fields) works for this usecase.