Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoekt: upgrade to grpc-ecosystem/[email protected] #648

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

ggilmore
Copy link
Contributor

@ggilmore ggilmore commented Sep 14, 2023

Fixes #643

This updates the grpc prometheus monitoring package to https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.0.0. Updating this required some minor application code changes (that I saw working locally).

@ggilmore ggilmore requested a review from a team September 18, 2023 17:02
@ggilmore ggilmore marked this pull request as ready for review September 18, 2023 17:03
@ggilmore ggilmore merged commit 089709e into main Sep 18, 2023
8 checks passed
@ggilmore ggilmore deleted the grpc-update-prometheus branch September 18, 2023 17:09
@henrik242
Copy link

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace directive in go.mod breaks go install github.com/sourcegraph/zoekt/cmd/zoekt@latest
3 participants