-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't have all spec markup using markdown when not using a .md file. #219
Comments
Or is it only abled to be handled mixing markdown and HTML? |
Nice point you have here, indeed these block types are not implemented yet. But you can mix HTML with markdown to make it work. It would be really useful to have those helpers generated from markdown like:
It's also a good task for a first contribution, so PR's are welcome. Here's the file you can start with https://github.com/sourcejs/Source/blob/master/core/lib/processMd.js. |
Theoretically other plugins can add even more block-types?
|
Right now plugins can do that only if a user sets those renderers in his config, like here https://github.com/mik01aj/sourcejs-md-react
|
@operatino I'l try to get this organised sometime if the next few days. I have not submitted a PR to any projects before, so I might need some hand holding for my first one in here. |
@custa1200 no worries, feel free to ask any advice, I'll be happy to help. You can also open a PR just to validate the approach, or ask for help, we've been doing the same with @ndelangen, he also was doing his first OS contributions to SourceJS. |
So I have added a PR with #222 hope it's ok. |
When I use the index.src.html spec file and use I can't understand from the examples how I add the:
.source_info
.source_warn
.source_doc
.source_a_d
.source_a_s
.source_hl
.source_a_hl
that are defined in https://sourcejs.com/docs/spec/
I tried doing a:
But it didn't work (I really wish there was an easy way to add markdown into markdown, excuse the \ )
also would it be better if they were in the format of .sourcejs-info, sourcejs-warn, etc? Which also begs the question should the code blocks be sourcejs-css instead of src-css to keep it all consistent? It would be great if somebody like a BA with no coding knowledge would be able write all the spec text using MD
The text was updated successfully, but these errors were encountered: