You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @evman182! Tks for the suggestion, it makes a lot of sense.
Would you mind sending a PR? Not sure if we have tests covering this part, but a test on this logic would be awesome too.
For the following line:
faraday-http-cache/lib/faraday/http_cache/strategies/by_url.rb
Line 102 in d05c590
my suggestion is it be changed to
This is based on the fact that rack and Faraday Header classes both seem to downcase the keys
https://github.com/rack/rack/blob/3897649e8740e560a5fa142f972121a119b26b5c/lib/rack/headers.rb#L110-L116
https://github.com/lostisland/faraday/blob/cc5d60776645d3d341ff0f425c45b3b3d48d98e0/lib/faraday/utils/headers.rb#L52-L63
The text was updated successfully, but these errors were encountered: