From 0247e4401363d42cb09b741ea839f8d41984eeec Mon Sep 17 00:00:00 2001 From: Shahzad Lone Date: Thu, 27 Jun 2024 18:28:39 -0400 Subject: [PATCH] PR: Rip out change detection steps --- .github/workflows/test-and-upload-coverage.yml | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/.github/workflows/test-and-upload-coverage.yml b/.github/workflows/test-and-upload-coverage.yml index 3931005a6c..0e07157f38 100644 --- a/.github/workflows/test-and-upload-coverage.yml +++ b/.github/workflows/test-and-upload-coverage.yml @@ -35,7 +35,6 @@ jobs: database-type: [badger-file, badger-memory] mutation-type: [gql, collection-named, collection-save] lens-type: [wasm-time] - detect-changes: [false] database-encryption: [false] include: - os: ubuntu-latest @@ -43,21 +42,18 @@ jobs: database-type: badger-memory mutation-type: collection-save lens-type: wasm-time - detect-changes: true database-encryption: false - os: ubuntu-latest client-type: go database-type: badger-memory mutation-type: collection-save lens-type: wasm-time - detect-changes: false database-encryption: true - os: macos-latest client-type: go database-type: badger-memory mutation-type: collection-save lens-type: wasm-time - detect-changes: false database-encryption: false ## TODO: https://github.com/sourcenetwork/defradb/issues/2080 ## Uncomment the lines below to Re-enable the windows build once this todo is resolved. @@ -65,21 +61,18 @@ jobs: ## client-type: go ## database-type: badger-memory ## mutation-type: collection-save -## detect-changes: false ## database-encryption: false - os: ubuntu-latest client-type: go database-type: badger-memory mutation-type: collection-save lens-type: wazero - detect-changes: false database-encryption: false - os: ubuntu-latest client-type: go database-type: badger-memory mutation-type: collection-save lens-type: wasmer - detect-changes: false database-encryption: false runs-on: ${{ matrix.os }} @@ -156,15 +149,9 @@ jobs: make deps:test - name: Run integration tests - if: ${{ !matrix.detect-changes }} run: make test:coverage - - name: Run change detector tests - if: ${{ matrix.detect-changes }} - run: make test:changes - - name: Upload coverage artifact - if: ${{ !matrix.detect-changes }} uses: actions/upload-artifact@v4 with: # Make sure the name is always unique per job as artifacts are now immutable.