From 21839d2c5364ca3a451bfa2814f781e4095e5706 Mon Sep 17 00:00:00 2001 From: Andrew Sisley Date: Fri, 7 Jun 2024 11:54:07 -0400 Subject: [PATCH] Remove completed todo --- .../query/one_to_many/with_group_related_id_alias_test.go | 3 --- .../query/one_to_many/with_group_related_id_test.go | 2 -- 2 files changed, 5 deletions(-) diff --git a/tests/integration/query/one_to_many/with_group_related_id_alias_test.go b/tests/integration/query/one_to_many/with_group_related_id_alias_test.go index bef01aee48..3b5a34d91c 100644 --- a/tests/integration/query/one_to_many/with_group_related_id_alias_test.go +++ b/tests/integration/query/one_to_many/with_group_related_id_alias_test.go @@ -16,7 +16,6 @@ import ( testUtils "github.com/sourcenetwork/defradb/tests/integration" ) -// TODO: Don't return grouped field if not selected. [https://github.com/sourcenetwork/defradb/issues/1582]. func TestQueryOneToManyWithParentGroupByOnRelatedTypeFromManySideUsingAlias(t *testing.T) { test := testUtils.RequestTestCase{ @@ -162,7 +161,6 @@ func TestQueryOneToManyWithParentGroupByOnRelatedTypeFromManySideUsingAlias(t *t executeTestCase(t, test) } -// TODO: Don't return grouped field if not selected. [https://github.com/sourcenetwork/defradb/issues/1582]. func TestQueryOneToManyWithParentGroupByOnRelatedTypeFromManySideUsingAliasAndRelatedSelection(t *testing.T) { test := testUtils.RequestTestCase{ @@ -626,7 +624,6 @@ func TestQueryOneToManyWithParentGroupByOnRelatedTypeWithIDSelectionFromManySide executeTestCase(t, test) } -// TODO: Don't return grouped field if not selected. [https://github.com/sourcenetwork/defradb/issues/1582]. func TestQueryOneToManyWithParentGroupByOnRelatedTypeFromSingleSideUsingAlias(t *testing.T) { test := testUtils.RequestTestCase{ Description: "One-to-many query with groupBy on related id field alias (from single side).", diff --git a/tests/integration/query/one_to_many/with_group_related_id_test.go b/tests/integration/query/one_to_many/with_group_related_id_test.go index 4eec467480..2855c8e46c 100644 --- a/tests/integration/query/one_to_many/with_group_related_id_test.go +++ b/tests/integration/query/one_to_many/with_group_related_id_test.go @@ -16,7 +16,6 @@ import ( testUtils "github.com/sourcenetwork/defradb/tests/integration" ) -// TODO: Don't return grouped field if not selected. [https://github.com/sourcenetwork/defradb/issues/1582]. func TestQueryOneToManyWithParentGroupByOnRelatedTypeIDFromManySide(t *testing.T) { test := testUtils.RequestTestCase{ Description: "One-to-many query with groupBy on related id (from many side).", @@ -301,7 +300,6 @@ func TestQueryOneToManyWithParentGroupByOnRelatedTypeIDWithIDSelectionFromManySi executeTestCase(t, test) } -// TODO: Don't return grouped field if not selected. [https://github.com/sourcenetwork/defradb/issues/1582]. func TestQueryOneToManyWithParentGroupByOnRelatedTypeFromSingleSide(t *testing.T) { test := testUtils.RequestTestCase{ Description: "One-to-many query with groupBy on related id (from single side).",