Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify use of installation recipes in the README #85

Closed
tpetchel opened this issue Mar 30, 2016 · 1 comment
Closed

Clarify use of installation recipes in the README #85

tpetchel opened this issue Mar 30, 2016 · 1 comment

Comments

@tpetchel
Copy link

In the README, we say things like:

### powershell4

Include the `powershell4` recipe in a run list, to install PowerShell 4.0 is installed on applicable platforms. If a platform is not supported or if it already includes PowerShell 4.0, an exception will be raised.

But it looks like you just get a warning.

[2016-03-30T14:27:03+00:00] WARN: PowerShell 4.0 is not supported or already installed on this version of Windows: 6.3.9600

https://github.com/chef-cookbooks/powershell/blob/master/recipes/powershell4.rb#L52

It also looks like you just get a warning if the platform is not supported.

https://github.com/chef-cookbooks/powershell/blob/master/recipes/powershell4.rb#L56

I might simply remove the statement "If a platform is not supported or if it already includes PowerShell 4.0, an exception will be raised." I would have to see if the same logic is used by the other installation recipes.

I felt strongly enough to file an issue because exception implies failure to me, like I would have to write a guard around it. Using this recipe is much easier than doing that. ;)

@tas50
Copy link
Contributor

tas50 commented Sep 2, 2016

I've clarified the behavior in the readme

@tas50 tas50 closed this as completed Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants