Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey error when opening a second instance of Hyper #43

Open
2 tasks done
cstrnt opened this issue Jul 10, 2018 · 3 comments
Open
2 tasks done

Hotkey error when opening a second instance of Hyper #43

cstrnt opened this issue Jul 10, 2018 · 3 comments

Comments

@cstrnt
Copy link

cstrnt commented Jul 10, 2018

  • I am on the latest hyperterm-summon version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: Windows 10

  • Hyper.app version: 2.0.0

  • hyperterm-summon version: 2.0.9

  • Link of a Gist with the contents of your .hyper.js: https://gist.github.com/Frexeptabel/a8bffdcc0d8e3bbd38086a848e171d69

  • Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere): N/A


Issue

When you open a new instance of Hyper while already having one instance open there will be the error message "Could not register 'summon' shortcut ()"

Steps to Reproduce

  1. Open an instance of Hyper with the summon plugin installed and setup
  2. Open a new instance of Hyper

Expected Result

There should be a list of fallback shortcuts / hotkeys when a new instance of hyper is opened. Otherwise you could add a number like 1-9 to your shortcut to access the instances. Anyway no error should be shown

Actual Result

An error is shown like described in the Issue

@dcalhoun
Copy link
Collaborator

Thanks for the report. This seems similar to #25.

  • When you say "new instance of Hyper" do you mean opening a second Hyper window?
  • Does the error occur for the first Hyper window?

@cstrnt
Copy link
Author

cstrnt commented Jul 17, 2018

Sorry for not clarifying! When talking about "new instance" I mean a new Hyper window!
And the error just occurs on the second window. I can just the shortcut for the first window like I could before. I just doesn't work on the second one (and all other new windows I would open).

I'm pretty sure that once the shortcut is registered it is applied to all windows of hyper and therefore there is an error because to windows can't use the same shortcut. But that's just my idea!

@dcalhoun
Copy link
Collaborator

Thanks for the clarification. There appears to be issues on both Windows and Linux. I run macOS and have never had an environment to debug this. I'll try to find a way to figure this out, but PR's are most definitely welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants