-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add failing tests cases for situations that we want the transform to support #7
Comments
Issue: there might be something wrong with named blocks 🤔 it could very well be something wrong with ember-template-recast because of the nature of the output File: app/components/audit-frequencies/page/edit.hbs Impact: searching for Edit actually it turns out it seems to only be affecting this one file 🤔 it doesn't seem to be a systematic problem |
Issue: it seems that we can't use the
writing out the minimal example here make it clear why there is an issue 🙈 we would need to use the File: app/components/user/modals/thankyou-form.hbs Impact: it seems like we only have exactly one occurrence of this 🎉 Fixed with #14 |
Issue: there are components with text arguments like: <Datatables::DatatableColumn @Label="Created By User" /> We should probably have a list of components with attributes that need to be translated. 1329 occurrences 320 occurrences Fixed with #22 |
Issue: translate of concat helper is not supported yet <span title={{concat "text1" "text2"}}>{{concat "aaa" "bbb"}} |
Issue: material-icon should not be translated Fixed with #23 |
Issue: · should not be considered as text. Same as which is currently supported. {{t "<span> {audit_user_fullName} · " audit_user_fullName=audit.user.fullName htmlSafe=true}} Fixed with #24 |
Text elements inside specific elements (flex-col,...) should not be merged: <div class="flex flex-col"> |
Note: we're keeping this open because it's a good resource of issues that we want to tackle, but we will decide which problems to fix closer to the end of the project when the MVP is working and we're in the "optimisation phase" 👍 |
Will keep open along with #5 for documentation. |
Now that we have a test suite with unit tests (added in #1) we can now develop the transform in somewhat of a TDD approach. We can create a number of failing tests that we can then go through and fix one-by-one.
This issue differs from #5 because we want to add tests for situations that we already know that we want to support, not things that are on the edge of the 80-20 split of work.
The deliverable for this task is to create PRs that will have failing tests because the code isn't actually doing what it's supposed to. The work associated with this task is not to fix the issue with the transform but instead collect failing examples that can be incorporated into the next iterations 👍
The text was updated successfully, but these errors were encountered: