Replace proof_of_sql_parser::intermediate_ast::Literal
and proof_of_sql_parser::intermediate_ast::Expression
with sqlparser::ast::Expr
in the proof-of-sql
crate
#353
Labels
refactor
Code cleanup or reorganization
Background and Motivation
This issue is a subtask in #235. In short since we plan to add more SQL features we plan to switch to the
sqlparser
crate which is a feature-rich,no_std
-compatible parser used by DataFusion, which is part of the Arrow ecosystem.Right now we already have some code that can convert intermediate AST from
proof-of-sql-parser
we use to sqlparser AST. Now we need to systematically replace instances ofproof-of-sql-parser
constructs with their corresponding sqlparser ones.Changes Required
proof_of_sql_parser::intermediate_ast::Literal
withsqlparser::ast::Expr
in theproof-of-sql
crate.proof_of_sql_parser::intermediate_ast::Expression
withsqlparser::ast::Expr
in theproof-of-sql
crate.Notes:
proof_of_sql_parser::intermediate_ast::UnaryOp
withsqlparser::ast::UnaryOp
in theproof-of-sql
crate #348proof_of_sql_parser::intermediate_ast::BinaryOp
withsqlparser::ast::BinaryOp
in theproof-of-sql
crate #349proof_of_sql_parser::Identifier
withsqlparser::ast::Ident
in theproof-of-sql
crate #350proof_of_sql_parser::posql_time
tosqlparser
#351proof_of_sql_parser::intermediate_ast::ResourceId
withVec<sqlparser::ast::Ident>
orsqlparser::ast::ObjectName
in theproof-of-sql
crate #352Literal
toExpr
as opposed toValue
is thatValue
doesn't handle timestamp type. If you have a clever solution that can useValue
instead ofLiteral
it is even better but usingExpr
is what we currently expect.The text was updated successfully, but these errors were encountered: