Remove obsolete TODO for logging unknown files. #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #247 +/- ##
=======================================
Coverage 70.1% 70.1%
=======================================
Files 28 28
Lines 1821 1820 -1
=======================================
Hits 1277 1277
+ Misses 402 401 -1
Partials 142 142
|
poszu
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes spacemeshos/go-spacemesh#4789
PoST should not complain about any files it finds in the data folder it doesn't know about. As explained in the issue there could be a lot of files that are just created by the OS that the operator of the node might not be aware about or can even remove from the directory.
We should keep the log as debug and close the issue.