From fcb3e91c868d39a4ae23d31d08ff104b73712bc7 Mon Sep 17 00:00:00 2001
From: "P. L. Lim" <2090236+pllim@users.noreply.github.com>
Date: Thu, 10 Aug 2023 16:36:52 -0400
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
---
 jdaviz/configs/default/plugins/subset_plugin/subset_plugin.py  | 2 +-
 jdaviz/configs/default/plugins/subset_plugin/subset_plugin.vue | 1 +
 jdaviz/configs/imviz/helper.py                                 | 2 +-
 jdaviz/core/region_translators.py                              | 3 ++-
 4 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/jdaviz/configs/default/plugins/subset_plugin/subset_plugin.py b/jdaviz/configs/default/plugins/subset_plugin/subset_plugin.py
index 0657709696..b62c7d6cf1 100644
--- a/jdaviz/configs/default/plugins/subset_plugin/subset_plugin.py
+++ b/jdaviz/configs/default/plugins/subset_plugin/subset_plugin.py
@@ -389,7 +389,7 @@ def vue_recenter_subset(self, *args):
         except Exception as err:
             self.set_center(self.get_center(), update=False)
             self.hub.broadcast(SnackbarMessage(
-                f"Failed to calculate centroid: {err!r}", color='error', sender=self))
+                f"Failed to calculate centroid: {repr(err)}", color='error', sender=self))
         else:
             self.set_center((x, y), update=True)
 
diff --git a/jdaviz/configs/default/plugins/subset_plugin/subset_plugin.vue b/jdaviz/configs/default/plugins/subset_plugin/subset_plugin.vue
index d8a6d8119a..4ad40b1601 100644
--- a/jdaviz/configs/default/plugins/subset_plugin/subset_plugin.vue
+++ b/jdaviz/configs/default/plugins/subset_plugin/subset_plugin.vue
@@ -83,6 +83,7 @@
           :value="item.value"
           style="padding-top: 0px; margin-top: 0px"
           :readonly="true"
+          hint="Subset was defined with respect to this reference data (read-only)"
         ></v-text-field>
         <v-text-field v-if="item.name !== 'Parent'"
           :label="item.name"
diff --git a/jdaviz/configs/imviz/helper.py b/jdaviz/configs/imviz/helper.py
index a69b1f855a..9d9c53ccde 100644
--- a/jdaviz/configs/imviz/helper.py
+++ b/jdaviz/configs/imviz/helper.py
@@ -219,7 +219,7 @@ def get_link_type(self, data_label_1, data_label_2):
         """Find the type of ``glue`` linking between the given
         data labels. A link is bi-directional. If there are
         more than 2 data in the collection, one of the given
-        label should be the reference data or look-up will fail.
+        labels should be the reference data or look-up will fail.
 
         Parameters
         ----------
diff --git a/jdaviz/core/region_translators.py b/jdaviz/core/region_translators.py
index 82f08d44cb..5da683f3ba 100644
--- a/jdaviz/core/region_translators.py
+++ b/jdaviz/core/region_translators.py
@@ -51,7 +51,8 @@ def _get_region_from_spatial_subset(plugin_obj, subset_state):
     from glue_astronomy.translators.regions import roi_subset_state_to_region
 
     # Subset is defined against its parent. This is not necessarily
-    # the current viewer reference data for when we can change that.
+    # the current viewer reference data, which can be changed.
+
     # See https://github.com/spacetelescope/jdaviz/issues/2230
     link_type = plugin_obj.app._jdaviz_helper.get_link_type(
         subset_state.xatt.parent.label, plugin_obj.dataset_selected)