Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click to center spatial subset on Imviz, disable click to drag #2202

Closed
wants to merge 1 commit into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented May 13, 2023

Description

This pull request is to fix #2189 . This needs a new version of glue, so I put this as draft for now.

  • I only enabled this for Imviz for now. Do we want to also do the same stuff for other viz that supports spatial subsets?

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added feature Feature request imviz labels May 13, 2023
@pllim pllim added this to the 3.5 milestone May 13, 2023
@github-actions github-actions bot added the documentation Explanation of code and concepts label May 13, 2023
@haticekaratay haticekaratay modified the milestones: 3.5, 3.6 May 25, 2023
Disable drag to update in Imviz.
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (9647215) 90.86% compared to head (f3d04be) 90.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2202      +/-   ##
==========================================
+ Coverage   90.86%   90.88%   +0.02%     
==========================================
  Files         152      152              
  Lines       17042    17082      +40     
==========================================
+ Hits        15485    15525      +40     
  Misses       1557     1557              
Impacted Files Coverage Δ
jdaviz/configs/imviz/plugins/viewers.py 94.96% <100.00%> (+0.03%) ⬆️
jdaviz/configs/imviz/tests/test_tools.py 100.00% <100.00%> (ø)
jdaviz/core/tools.py 87.15% <100.00%> (+0.95%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim
Copy link
Contributor Author

pllim commented Oct 25, 2023

Looks like no one wants this, so closing.

@pllim pllim closed this Oct 25, 2023
@pllim pllim deleted the click-clack-cen branch October 25, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Explanation of code and concepts feature Feature request imviz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tool to recenter any Subset (even compound ones) with a click
3 participants