Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiImage workflow changes #47

Closed
4 tasks
stscieisenhamer opened this issue Nov 23, 2015 · 6 comments
Closed
4 tasks

MultiImage workflow changes #47

stscieisenhamer opened this issue Nov 23, 2015 · 6 comments

Comments

@stscieisenhamer
Copy link
Contributor

As per #32, will change the workflow as follows:

  • MultiImage becomes a global plugin, and is started at any point
  • To add an image, an explicit keystroke is needed.
    • Option to add automatically.
  • Where the image comes from is irrelevant
  • To cycle through the images, a different set of keystrokes, or overload of the arrow keys, will cycle through the JUST the images added to MultiDim, as long as that plugin has focus. Again, the cycling would cross channels if necessary.
  • Make images removable.
  • The image in the main viewer does not actually have to be part of the stamps. <- Need to think about that.

Steps for implementation

@pllim
Copy link
Contributor

pllim commented Feb 22, 2016

👍 global plugin. This automatically solves the issue of cross-channel alignment.

👎 to keystroke. Instead, this can be drag-and-drop (more intuitive).

👎 to keystroke override because "plugin focus" does not apply to global plugin. Instead, we can have our own "Prev" and "Next" buttons to cycle through them?

👍 removable image. Also, an image deleted from a channel needs to be removed from this also. But what if an image is still in channel but simply fell out of Datasrc cache?

👍 not forcing main viewer image to take part. I think this is a natural by-product of making auto-add optional.

@pllim
Copy link
Contributor

pllim commented Aug 30, 2016

@stscieisenhamer and @hcferguson, I am playing with the idea to completely remove MultiImage and MIPick. Instead, similar functionality can be achieved using a combination of existing plugins from Ginga itself. For example, WCSMatch, Pick, Blink, and multiple channels on a tiled workspace. What do you think?

@hcferguson
Copy link

hcferguson commented Aug 30, 2016

@pllim can you do a demo sometime?

EDIT: Removed duplicate comments. Corrected username.

@pllim
Copy link
Contributor

pllim commented Aug 30, 2016

If we have another visualization sprint scheduled, this can be part of that sprint.

@pllim
Copy link
Contributor

pllim commented Jan 27, 2017

@hcferguson , with the latest dev Ginga (as of Jan 27, 2017), I believe the following workflow using core Ginga, without the special MultiImage and MIPick plugins here, effectively supersedes those 2 plugins, which I am in favor to get rid of (which will also conveniently close a bunch of open issues):

  1. Open the images of interest from command line, each image in its own channel using ginga --sep s*_sci.fits command. Also see How to place each image in a different channel from command line ejeschke/ginga#428.
  2. Change the "Workspace" drop-down menu option to "Grid".
  3. Start WCSMatch global plugin and set "Reference Channel" to "Image" (or whichever channel you want to use as primary).
  4. Start Pick local plugin in the primary channel.
  5. Zoom and pick your object of interest.

Screenshot of the result is attached. In this screenshot, every channel is using its own auto-levels for scaling. You can manipulate Ginga configuration to have them all on the same scale, but that option is not pretty for this particular example:

screenshot-ginga image

What do you think?

@pllim
Copy link
Contributor

pllim commented Feb 23, 2018

xref #152.

@pllim pllim closed this as completed Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants