-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obtain or generate NIRCam WFE maps for coronagraphic field points #180
Comments
Comment by mperrin @JarronL I also wanted to ping you again on this one. It sounded like you could help provide us with info for the field dependent WFE terms and other factors for the coronagraph field points. Is that something you could provide in the near term? We're hoping to get a next release out timed for the June AAS meeting incorporating CV and OTIS results, etc, and could include this in that. |
Update - I'm also asking Randal if he can help provide such WFE maps for the coronagraphic field points. |
Update part 2: @JarronL has provided the answers!
|
This will take some careful thought for how to integrate into the WFE classes in WebbPSF. May want to be its own subclass? Compared to the regular NIRCam WFE, it adds a wavelength dependence to the Zernikes. And besides which, it breaks the idea of a 1:1 mapping between focal plane coords in pixels and the WFE lookup, since there's the prism wedges. Sketch of a possible implementation, based on current code architecture:
|
Nice suggestion! I like it. In terms of next steps, I'm actually taking a research leave right now (mini-sabbatical), so am not likely to make any additions to webbpsf in the near future. Perhaps Shannon or Marcio might be able to help with implementing this, though. Or do you think you might want to submit a PR for this yourself? Separately those focus plots remind me, the focus model could use some updating. It seems pretty clear now the measured LW defocus at 3.2 microns is a property of the F323N filter, not something inherent in the optical system. We should consider updating the defocus model to switch that extra defocus on only for that filter name, and to use more like the LW ideal at that wavelength for other filters. |
I can go about submitting the pull request. I've already implemented a rewrite of that function in my local WebbPSF copy, which includes both the WFE information for Lyot pupils as well as the more representative LW focus model (ie., excluding the F323N filter). In the case of F323N, I simply do a check on the instrument filter selection and perform an additional defocus. The only other thing that differs is that instead of performing a linear interpolation on the values in |
This all was implemented in PR #283 |
Issue by mperrin
Tuesday Dec 12, 2017 at 22:29 GMT
Originally opened as mperrin/webbpsf#180
Either find WFE maps from the IPR LEDs, or generate from Zemax.
This should hopefully include wavelength-dependent terms for the NIRCam-internal WFE (from the refractive optics being used at large field angle), and also for the wedge chromatic term. (see also spacetelescope/stpsf#14)
The text was updated successfully, but these errors were encountered: