Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginate by 250 instead of by 50 #116

Closed
vfonic opened this issue Feb 28, 2018 · 2 comments
Closed

Paginate by 250 instead of by 50 #116

vfonic opened this issue Feb 28, 2018 · 2 comments

Comments

@vfonic
Copy link
Contributor

vfonic commented Feb 28, 2018

You could add limit: 250 to the default opts here: https://github.com/spark-solutions/spree_shopify_importer/blob/master/app/services/spree_shopify_importer/connections/base.rb#L21

It will speed up large stores import by almost 5 times by returning 250 items instead of 50 per page.
@Argonus
Copy link
Contributor

Argonus commented Mar 8, 2018

@vfonic I will check it by the weekend ;) Thanks!

@vfonic
Copy link
Contributor Author

vfonic commented Mar 8, 2018

Opened on spree-contrib repo: spree-contrib/spree_shopify_importer#2

@vfonic vfonic closed this as completed Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vfonic @Argonus