Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow removal of signing keys more strictly #2647

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Oct 19, 2024

  • Don't allow removal of (Ed)DSA keys for pre-validated updates (delta updates, .aar updates)
  • Don't allow removal of code signing identity in new update (at minimum, an adhoc signature can be used)

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)
  • Tested updating regular EdDSA + code signed app
  • Tested updating EdDSA app that drops code signing (fails)
  • Tested updating regular EdDSA + code signed app with delta update
  • Tested updating EdDSA app that drops code signing with delta update (fails)
  • Tested updating EdDSA app that drops EdDSA key with delta update (fails)

macOS version tested: 15.0.1 (24A348)

* Don't allow removal of (Ed)DSA keys for pre-validated updates (delta updates, .aar updates)
* Don't allow removal of code signing identity in new update (at minimum, an adhoc signature can be used)
@zorgiepoo zorgiepoo added this to the 2.7 milestone Oct 19, 2024
@zorgiepoo zorgiepoo merged commit d04faab into 2.x Oct 21, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the basic-signing-policy-changes branch October 21, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant