-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: position the bar above the horizontal center #25
base: main
Are you sure you want to change the base?
Conversation
Nope, that actually seems wrong if the object is rotated. Looking into it further. |
Seems like this happens with the original code as well: the health bar rotates with the object. I thought it would act more like a billboard. |
yeah it's supposed to, good find |
We may have to rethink the offset. With the changes in this PR, dual bars would overlay each other when viewed top down. In the multi-bar scenario, the bars' positions shouldn't change relative to each other even when the camera is rotated/tilted |
what do you think about having the offset supplied as a vec3 instead of f32, where the components are applied as follows: (every angle in between orthogonal/parallel would be a percentage of the rotation, i.e. 45 degrees would be 50%) |
It's hard for me to say without playing around with it :) |
Resolves #24
This is what it looks like after the change: