Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map pin active state is not removed until a different map pin is made active #65

Open
cbessee opened this issue Jul 11, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@cbessee
Copy link
Contributor

cbessee commented Jul 11, 2019

To reproduce

Select a vendor booth on the map and observe that the pin is styled according the active state. Close the bottom panel and note that the active state still remains. Select a DIFFERENT map pin and note that the active state is removed before applying to the newly selected map pin. This causes a brief, distracting flash of the previously selected map pin

Suggested fix

We should remove the pin active state when closing the bottom drawer rather than when selecting a new map pin

@cbessee cbessee self-assigned this Jul 11, 2019
@danielduhh danielduhh added the bug Something isn't working label Jul 11, 2019
@danielduhh
Copy link
Contributor

This only happens when selecting the close button in the bottom panel.

The deselect map icon logic exists in the SwipableDrawer onClose, but should also exist here:
https://github.com/spatialdev/react-seafood/blob/development/src/components/bottomDrawer/bottomDrawer.js#L121

@slindy23
Copy link

I disagree with @danielduhh on this. It happens every time I click on a map pin and I never touch the bottom panel.

@danielduhh
Copy link
Contributor

There's two problems

  1. the jumpy animation when you click a map pin
  2. the active state doesn't get removed when selecting the close icon on the bottom panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants