Interactivity refactor #112
Conversation
| export let onDragend = undefined | ||
| export let onMousedrag = undefined | ||
|
|
||
| // Touch interactions |
There was a problem hiding this comment.
I noticed the distinction between mouse and touch interactions here. If I'm not mistaken the original event manager provided only one 1 API that uses either mouse or touch in the background based on whatever detectIt detects to be present. Is this a change from that approach?
There was a problem hiding this comment.
Yes, mouse and touch interactions are now completely separated. Touch does not have an equivalent to mouseover and mouseout, and mousemove works differently for touch too. To force everything under one API meant that we had to create a touch equivalent of mouseover and mouseout, which we did by looking at the timestamps of the events, calculating the time elapsed between down and up etc. There were two problems with this approach:
- The 'treshold' that determined whether something was a
touchoveror atouchdownwas fixed and unchangeable, and you might want to have more control over this - The 'treshold' is only necessary when you needed both
touchoverandtouchdown. This is not always necessary and in fact should be avoided when possible IMO. If you just need to know whether the user put his/her finger down, and you don't care for how long, you now have a problem, because the 'treshold' is built in. We can still support different interactions by letting the user take care of this 'treshold', which will be a bit harder, but that's a good trade-off for a more flexible and robust API I think (and also to discourage this 'different-interactions-based-on-how-many-milliseconds-your-finger-is-down' behavior).
src/helpers/nextTick.js
Outdated
| @@ -0,0 +1,3 @@ | |||
| export default function (callback) { | |||
There was a problem hiding this comment.
Should we use Svelte's built-in tick() instead? https://svelte.dev/docs#tick
There was a problem hiding this comment.
Ah I was looking for something like this but couldn't find it. I will use this instead
|
The netlify deploy fails but we can ignore this since we're restructuring the |
…tworkslab/florence into interactivity-refactor
blockReindexingoption for Graphic, Section, Marks and Layers (this is useful when drawing new geometries that have interactions attached to them, like drag. If you are dragging, you don't want the mark/layer to reindex every time the data changes)createZoomHandlerandcreatePanHandlerstructure (might be a bit awkward, I'm open for improvements to this)geometryUtilsfromtransshapeTODO: