-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation party 🎉 #67
Comments
Some suggestions based on what I observed from the Interactive Data Vis class using vue-gg for the first time:
before showing any fancier stuff involving mapping, dataframes, scales, etc. This could also be more an issue with Vue literacy.
requires a data input with the ff format:
whereas creating the chart on the right with
I am not sure if this is something that should just be addressed in the class itself or if it is worthwhile to include in the docs. |
In reply to @bianchi-dy her comment above:
As for 2., we will make some strides here tomorrow! I compiled a small todo list of stuff that was still in the back of my mind for tomorrow:
Anything else? |
This is currently planned for the 22nd of March, but that is still negotiable.
If the party is planned during the day I can probably join in near the end, and then go through all the diffs after everyone in SG goes home, to make small corrections/fix style consistencies?
Before we start, however, we need to make some rules on styling to keep everything consistent. I suggest the following rules, based on my own preferences and what I have enforced so far:
Titles/headers
Some header
is fine,Some Header
is not.1 and 2 here exist so that you can link to paragraphs from other files with
<file>.md#some-header
without any problemsStructure
Component tag
,Description
, andProps
header, and optionally aUsage
header. It is ok to put shorts examples of usage in theProps
header if that seems appropriate, but limit the (complex) examples as much as possible to theUsage
header.Props table
Props
section that contains one or more tables that document the props. Make sure these tables always have aProp
,Required
,Types
,Default
, andDescription
column. Make sure these are always spelled in the same way, with a capital letter. TheUnits
column is optional and should only be used if there might exist confusion about what the units are, like local coordinates vs screen pixels. BTW: this one is not consistent right now, because it is sometimes calledUnit(s)
, so we should still make that consistent.Prop
column: here we mention the kebab-case name of the prop. Soline-width
instead oflineWidth
. If we mention the prop name in the text below the table, we also use the kebab case version, AND we use backticks to highlight the name.Required
column: can only betrue
,false
, ordepends
. If the value isdepends
, the text below the table must describe under what conditions the prop is allowed, and when the prop shouldn't be used.Types
column: if only one type is allowed, we should use for exampleNumber
. If multiple types are allowed, we use[
and]
, so for example[Number, String]
. When we talk about types in the the text below the table, we always use a capital (so for example, "the prop can be passed String data if so and so...").Default
column: Can be a value orundefined
.Description
column: Must be a 1-sentence description. If that is not enough, use the text under the props table for a longer description. The sentence must start with a capital letter, but should not end with a punctuation mark.Units
column: should beScreen pixels
,Local coordinates
, or something else, but keep it short.Other guidelines:
Concepts
. It is good to reuse concepts, because it will be easier for us and our users to reason about the logic behind the library if we have concepts that return in different places and always work in the same way. See theScaling
concept for an example.Any other guidelines? Or any suggestions on improving the ones I just proposed?
Also, should we add a
documentation
label to the GH issues?The text was updated successfully, but these errors were encountered: