-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
num_branches
missing in the code in sorting examples?? (and other questions)
#35
Comments
Hello ratthachatt, thank you for looking into our work. I am sorry for the late reply, but we were attending a conference last week.
The parameter
You are correct, that is actually a mistake, since Thank you for noticing the mistake, which we will soon rectify.
The Repeat operation is indirectly implemented for example by using the
I assume that are talking about the Graph of Operations here. While this graph is the same for both operations, the used prompts differ (see examples/sorting/sorting_032.py, lines 209 to 212 for selection logic and lines 32 to 45 for IO prompt and lines 47 to 89 for the Chain of Thought prompt). Have a nice day. |
Dear @rgersten , thank you for your kind explanation! This answer most of my questions, except one about I may still miss something, but could you please give me examples, where this parameter For example (as mentioned above), it looks like it is used here:
BUT if we go further to see, e.g., Thank you again in advanced, and have a nice day too! |
Hello ratthachat,
You are correct, that this feature (letting the language model do the branch inside a single prompt-answer pair) is currently not used in any of the provided use cases. However it is an option for the user to employ this parameter similar to how, for example, the inputs and their lengths are used as parameters in the merge prompt in the sorting use case. Please have a look as reference at lines 178 to 183 for the setting of the parameters and lines 139 to 155 for the merge prompt in the source code of the sorting use case for 32 elements: https://github.com/spcl/graph-of-thoughts/blob/main/examples/sorting/sorting_032.py We initially experimented with that parameter, however ultimately decided to query the LLM for different answers using the API instead, since it requires less parsing and therefore avoids related errors.
You are welcome and thank you. Have a nice day. |
fix mistake in the sorting example for 32 elements, which has no impact, since the respective parameter is not used in the implementation of the generation prompt reported in issue #35
Thanks again @rgersten , now I better understand the logic.
could you please give some code example (e.g. the one you made experiments) on I just want to make sure I understand your design correctly and concretely. |
Hello ratthachat,
I found the following example for one of our old experiments: def generate_prompt(
self, num_branches: int, current_state: str, original: str, **kwargs
) -> str:
...
num_next_steps = (
"Possible next steps:\n"
if num_branches < 1
else f"Provide {num_branches} possible next steps:\n"
)
... I hope that example will help with the understanding of the Have a nice day. |
Hi, thank for the great paper and code!
However, I may be missing somethings but I find few strange implementations:
For example in sorting_032.py
tot()
, 2nd parameter is used in Generate i.e.Generate(1, 20)
got()
, 1st parameter is used in Generate i.e.Generate(2, 1)
The 1st parameter is then used here:
BUT in
SortingPrompter.generate_prompt
e.g. herethere is no used about this parameter at all. (why??)
Other questions:
Repeat(k)
is mentioned, but there is none in the code (why?)io()
andcot()
are the same (why?)Thanks again and looking forward on clarification
PS. it would be great if the authors provide a colab that is ready to run for this repository.
At the moment, it is quite difficult to quickly set up and try things.
The text was updated successfully, but these errors were encountered: